Update toolchain to Go 1.23.1 #3249
Conversation
|
Looks like something's up with the coverage code on the alt build. Think that will need a proper fix. |
src/test/coverage_test.go
Outdated
| goCoverageFile2 = "src/test/test_data/go_coverage_2.txt" | ||
| goCoverageFile3 = "src/test/test_data/go_coverage_3.txt" | ||
| pythonCoverageFile = "src/test/test_data/python-coverage.xml" | ||
| // TODO(peterebden): Remove the 'x' on these once we update go-rules again |
There was a problem hiding this comment.
I think there's an issue here where the coverage variables we create have the prefix goCover and so do these; they later get somehow detected as coverage vars. I guess something in 1.23 must have changed to find them.
The easiest / more correct fix is probably to make go-rules use a less usual coverage variable name. I'm changing these for now so I don't have to block on another round of updates there.
There was a problem hiding this comment.
I've reverted this since I've ended up getting the better fix in go-rules.
plugins/BUILD
Outdated
| @@ -1,7 +1,8 @@ | |||
| plugin_repo( | |||
| name = "go", | |||
| plugin = "go-rules", | |||
| revision = "v1.20.1", | |||
| revision = "02f5910e44bb8274b5bdb80ec80188a9d180f59f", | |||
There was a problem hiding this comment.
Need to revert this to the official go-rules before merging.
There was a problem hiding this comment.
Yup thanks, have done - wanted to get a build on here against it to check that really did fix it.
Forgot in #3248 that this would be necessary too.