fix: match all conditions in config_setting #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the documentation above the config_setting rule, it should match all conditions in values. Bazel works the same way: https://docs.bazel.build/versions/master/configurable-attributes.html Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
sagikazarmark
force-pushed
the
fix-config-setting
branch
from
907ee69 to
83d771d
Compare
sagikazarmark
added a commit
to sagikazarmark/please-go-modules
that referenced
this pull request
Oct 17, 2020
See thought-machine/please#1306 Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation above the config_setting rule,
it should match all conditions in values.
Bazel works the same way:
https://docs.bazel.build/versions/master/configurable-attributes.html