Updated isReceiveTimeout() to check for Preamble and SFD timeout as well #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isReceiveTimeout() currently only checks to see if RXRFTO is high, but there are two other potential timeout flags-- the RX SFD timeout is enabled by default and the RX Preamble timeout can be enabled in the DRX_PRETOC (sub)register. It seems like this function should check all three of these bits rather than just RXRFTO. Will make separate pull request to include #defines for RXPTO_BIT and RXSFDTO_BIT (21 and 26, respectively)
|
@alessandroportela I had a short look. A general good practice hint: add your thoughts as comment into the source file. Because later nobody looks into commit or pull request notes :) |
|
Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isReceiveTimeout() currently only checks to see if RXRFTO is high, but there are two other potential timeout flags-- the RX SFD timeout is enabled by default and the RX Preamble timeout can be enabled in the DRX_PRETOC (sub)register. It seems like this function should check all three of these bits rather than just RXRFTO.
Will make separate pull request to include #defines for RXPTO_BIT and RXSFDTO_BIT (21 and 26, respectively)