Make the setSize method of RenderingPanel protected #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The offsetWidth and offsetHeight may not work as expected in some scenarios. It is important to give a choice to the developer in those cases. We have hit that bug on chrome. It the offsetWidth stopped working when the root panel is in an iframe. Therefore, it could be good to make the setSize method of RenderingPanel overridable.
thothbot
added a commit
that referenced
this pull request
Sep 20, 2015
Make the setSize method of RenderingPanel protected
|
Thanks for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The offsetWidth and offsetHeight may not work as expected in some scenarios. It is important to give a choice to the developer in those cases. We have hit that bug on chrome. The offsetWidth stopped working if the root panel is in an iframe. Therefore, it could be good to make the setSize method of RenderingPanel overridable.