Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPIKE] Make micropipenv an alternative to Pipenv #151

Open
fridex opened this issue Jan 4, 2021 · 25 comments
Open

[SPIKE] Make micropipenv an alternative to Pipenv #151

fridex opened this issue Jan 4, 2021 · 25 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@fridex
Copy link
Collaborator

fridex commented Jan 4, 2021

Is your feature request related to a problem? Please describe.

See upstream discussions as this one pypa/pipenv#2873 (still active comments in 2020). Pipenv seems to be slow in some cases and inaccurate (see for example thoth-station/adviser#1613).

Describe the solution you'd like

I was wondering how expensive and complicated it would be to make micropipenv an alternative to Pipenv. We could take a look at pip's new resolver (available in pip>=20.3) and see if the interface is easy to reuse to create a lightweight alternative to Pipenv.

Describe alternatives you've considered

Use Pipenv.

Additional context

This is solely a spike and just heads up on this topic. I'm not sure now how complicated the change would be and if we could seamlessly reuse the new pip's resolver.
@fridex
Copy link
Collaborator Author

fridex commented Jan 4, 2021

Friendly ping to pip/Pipenv folks if this would be something interesting to them.

@pradyunsg @uranusjr

@uranusjr
Copy link

uranusjr commented Jan 5, 2021

You probably want to talk to pip-tools maintainers, who are working to change their resolver to use pip’s new resolver as well IIUC.

@fridex
Copy link
Collaborator Author

fridex commented Jan 5, 2021

You probably want to talk to pip-tools maintainers, who are working to change their resolver to use pip’s new resolver as well IIUC.

Thanks for the reply. Sounds like the idea is not novel and we could eventually combine efforts. Thanks!

@fridex fridex mentioned this issue Jan 5, 2021
Closed
@fridex
Copy link
Collaborator Author

fridex commented Feb 8, 2021

Related: pypa/pipenv#4587 (comment)

@sesheta
Copy link
Member

sesheta commented May 9, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 9, 2021
@fridex
Copy link
Collaborator Author

fridex commented May 10, 2021

/remove-lifecycle stale

@sesheta sesheta removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 10, 2021
@goern
Copy link
Member

goern commented Jun 15, 2021

/priority important-soon

@sesheta sesheta added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jun 15, 2021
@goern
Copy link
Member

goern commented Jul 8, 2021

/kind feature
/sig docs

@sesheta sesheta added kind/feature Categorizes issue or PR as related to a new feature. sig/docs labels Jul 8, 2021
@sesheta
Copy link
Member

sesheta commented Aug 7, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 7, 2021
@fridex
Copy link
Collaborator Author

fridex commented Aug 9, 2021

/remove-lifecycle rotten

@sesheta sesheta removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 9, 2021
@sesheta
Copy link
Member

sesheta commented Sep 10, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta
Copy link
Member

sesheta commented Sep 10, 2021

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta closed this as completed Sep 10, 2021
@fridex
Copy link
Collaborator Author

fridex commented Sep 10, 2021

/remove-lifecycle rotten
/reopen
/triage accepted

@sesheta sesheta reopened this Sep 10, 2021
@sesheta
Copy link
Member

sesheta commented Sep 10, 2021

@fridex: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/reopen
/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Sep 10, 2021
@sesheta
Copy link
Member

sesheta commented Oct 10, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta
Copy link
Member

sesheta commented Oct 10, 2021

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fridex
Copy link
Collaborator Author

fridex commented Oct 11, 2021

/remove-lifecycle rotten

@fridex fridex mentioned this issue Dec 13, 2021
Closed
@sesheta
Copy link
Member

sesheta commented Jan 9, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2022
@fridex
Copy link
Collaborator Author

fridex commented Jan 10, 2022

/remove-lifecycle stale

@sesheta sesheta removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 10, 2022
@sesheta sesheta added sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. and removed sig/docs labels Mar 2, 2022
@sesheta
Copy link
Member

sesheta commented Jun 1, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 1, 2022
@sesheta
Copy link
Member

sesheta commented Jul 1, 2022

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 1, 2022
@sesheta
Copy link
Member

sesheta commented Jul 31, 2022

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta sesheta closed this as completed Jul 31, 2022
@sesheta
Copy link
Member

sesheta commented Jul 31, 2022

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frenzymadness
Copy link
Collaborator

@fridex do you want to continue with this? I'm not sure I fully understand the intention here. IIUC micropipenv now installs packages in a loop until all of them are installed and if some fails they're moved to the end of the queue. This proposal is about using pip resolver for it so the order of installed packages would be determined first and then installed so there should be no failures. Is that correct?

@frenzymadness frenzymadness reopened this Aug 1, 2022
@goern
Copy link
Member

goern commented Aug 8, 2022

/lifecycle frozen
/priority backlog

@sesheta sesheta added priority/backlog Higher priority than priority/awaiting-more-evidence. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Aug 8, 2022
@codificat codificat removed the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Sep 19, 2022
@codificat codificat moved this to 🏗 In progress in Planning Board Sep 24, 2022
@Gkrumbach07 Gkrumbach07 moved this from 🏗 In progress to 📋 Backlog in Planning Board Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning Board
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
6 participants
@goern @uranusjr @codificat @fridex @frenzymadness @sesheta