Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the project Meteor-compatible #51

Merged

Conversation

mayaCostantini
Copy link
Contributor

Related Issues and Dependencies

Related to #31

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

Adding the necessary files to build a Jupyter Book from the repository, so that users can learn about Thoth datasets by visualizing both notebooks and markdowns in a practical format.

Description

  • Added the necessary files (_config.yml and _toc.yml) that will allow to build the content of the Book from the repo
  • Configured the .aicoe-ci.yaml file for build

@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 18, 2021
@mayaCostantini
Copy link
Contributor Author

/assign @pacospace

@@ -0,0 +1,31 @@
title: Thoth Datasets
author: Thoth Station, Red Hat Artificial Intelligence Center of Excellence (AICoE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goern do we have to change this already?

_toc.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@pacospace pacospace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! 🚀

@sesheta
Copy link
Member

sesheta commented Nov 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacospace

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2021
@sesheta sesheta merged commit 78a9fe8 into thoth-station:master Nov 19, 2021
@mayaCostantini mayaCostantini deleted the make-project-meteor-compatible branch November 19, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants