Fix race condition in WorkRelation ordinal assignment using advisory locks #719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve a race condition in
WorkRelation::create()where concurrent insertions could compute the samerelation_ordinalfor inverse relations, triggering duplicate key violations onwork_relation_ordinal_type_uniq.The fix includes:
max(relation_ordinal)selection fully inside the transactionpg_advisory_xact_lockkeyed on (related_work_id, inverse relation type) to serialise ordinal assignment for each work/type pair