Draft
Conversation
Member
tinyjin
commented
Feb 13, 2026
- renamed the existing Lottie example to Animation to align with thorvg.example
- added a lottie.ts sample
There was a problem hiding this comment.
Pull request overview
This PR updates the playground showcase to better align with the upstream/native example naming by renaming the existing Lottie playback example to “Animation”, and adds a new “Lottie” grid sample.
Changes:
- Renamed the existing Lottie example to
Animation(new id + thumbnail + native example reference). - Added a new
lottie.tssample that renders many Lottie animations in a grid. - Added a new thumbnail asset for the renamed Animation example.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
playground/public/assets/animation-thumbnail.png |
Adds a thumbnail for the renamed Animation showcase entry. |
playground/lib/examples/animation.ts |
Renames the previous Lottie example to “Animation” and changes its id/thumbnail/reference. |
playground/lib/examples/lottie.ts |
Introduces a new Lottie grid sample that fetches many Lottie JSONs and animates them. |
playground/lib/examples/index.ts |
Wires the renamed Animation example and the new Lottie example into the showcase list. |
Comments suppressed due to low confidence (2)
playground/lib/examples/animation.ts:6
AnimationExampleis exported in PascalCase, but the rest of the examples in this folder use lowerCamelCase (e.g.,basicShapesExample,pictureJpgExample). To keep naming consistent and avoid special-casing imports/exports, rename this export to match the established*Examplenaming pattern and update its import/usage inexamples/index.ts.
playground/lib/examples/animation.ts:5- Changing the example
idfromlottie-animationtoanimationwill break existing deep links/bookmarks to/showcase/lottie-animationand any saved state keyed by the old id. Consider keeping the old id (and only updating title/thumbnail), or adding an alias/redirect path so both ids resolve to the same example.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🚀 Playground preview deployment ready! 🎮 Playground: https://thorvg-playground-qv5auinjg-thorvg-web.vercel.app |
- renamed the existing Lottie example to Animation to align with thorvg.example - added a lottie.ts sample
e958147 to
50b0cea
Compare
|
🚀 Playground preview deployment ready! 🎮 Playground: https://thorvg-playground-4i5yyvfew-thorvg-web.vercel.app |
Member
|
Let's consider adding this after performance stabilization |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.