chores - removed skottie/dotlottie redundants#201
Merged
Conversation
hermet
force-pushed
the
hermet/cleanup
branch
from
240aff3 to
90a8ca2
Compare
There was a problem hiding this comment.
Pull request overview
This pull request removes redundant Lottie player dependencies and their associated code from the perf-test application. The changes eliminate skottie (CanvasKit-based) and dotlottie player implementations, consolidating on ThorVG as the sole Lottie player solution.
Changes:
- Removed three unused Lottie player packages (@lottiefiles/dotlottie-react, @lottiefiles/react-lottie-player, canvaskit-wasm) and their dependencies from package.json
- Deleted the SkottiePlayer component (perf-test/components/SkottiePlayer/index.tsx) entirely
- Removed player implementations for player IDs 3 and 4, along with related initialization code and imports from app/page.tsx
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| perf-test/package.json | Removed @lottiefiles/dotlottie-react, @lottiefiles/react-lottie-player, and canvaskit-wasm dependencies |
| perf-test/yarn.lock | Removed lockfile entries for @lottiefiles/dotlottie-react, @lottiefiles/dotlottie-web, and canvaskit-wasm packages |
| perf-test/components/SkottiePlayer/index.tsx | Completely deleted the SkottiePlayer component file |
| perf-test/app/page.tsx | Removed imports for dotlottie and skottie players, removed player ID 3 and 4 rendering logic, and removed CanvasKit initialization code |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hermet
force-pushed
the
hermet/cleanup
branch
from
90a8ca2 to
997fcdb
Compare
tinyjin
force-pushed
the
hermet/cleanup
branch
from
997fcdb to
78de927
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tinyjin
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.