web player migration from thorvg #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduce a `lit`(https://lit.dev) - lit is most popular web component builder - with lit, we can build high-performance WP with less code
- define separated model for better readability of interface - implemented thorvg basic features added features: - Add version info - Support setBgColor - Support save2gif - Support bounce mode - Support intermission - Support skipping needless animation by dom visible
- `index.html` : basic example - `benchmark.html` : to check FPS, memory usage, latency(ms)
- added new exportable type `tvg` - support jpg/png/svg/tvg load
- Support `resize` method - Add `resolution` prop
when `lottie-player` has no `src` at first rendering, programmatical load wasn't working
`stop` worked like `pause`, when stopping animation, frame should be at 0
improved code consistency: - removed double-quotes on string literal. - removed double-equals (==) - updated comments
Call the explicit memory deletion—binded in function `delete()`, which is highly recommended by the Memory management in Emscripten guideline. The function will guarantee that the WASM module is cleaned up from the memory. see: https://emscripten.org/docs/porting/connecting_cpp_and_javascript/embind.html#memory-management Additionally, WASM module's initialization part has been refactored to correspond to the change.
This change would help on testing dynamic creation/deletion of component.
Compared the FPS with ThorVG viewer at 1664x1664 resolution. This minor tweak improves the performance by 2 to 5 FPS.
Previously, the Intersection Observer doesn't filter hidden animations when page just loaded. Ensure that the only visible animations to be played. Hidden resources will be frozen in the initial load.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hermet
changed the title
- added thorvg submodule with v0.13.x branch, - rearranged the relative path of it for wasm js.
|
In Currently, |
tinyjin
approved these changes
May 27, 2024
Good idea. please do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thorvg/thorvg#2297