LDAP fail

[gavilareal]

On version 2.9.7, an old issue came back:

#1151
#1130

[thorsten]

@gabrielvilareal please check 2.9.8, released today.

[gavilareal]

hi @thorsten

I tried to install version 2.9.8 but it doesn't work. I think that there are missing libs on directory inc/libs/

Anyway, I looked at inc/PMF/Ldap.php and constant still there on line number 120:

                if (!ldap_set_option($this->ds, constant($key), $value)) {

The solution I did in a system we have installed was to remove this constant function:

                if (!ldap_set_option($this->ds, $key, $value)) {

[thorsten]

First, I see the files in the ZIP package:

I'll fix the other issue now.

[nighknight]

I am sorry to bring up this topic again, but imho this fix needs to be reverted.

From my understanding the problem is heavily connected to the values specified in phpmyfaq/config/constants_ldap.php:

Currently (since commit 1c099d4), the parameters are specified there as strings.

In this case, you need to use constant($key) in phpmyfaq/inc/PMF/Ldap.php.

At the moment there are strings used in the config file, but no constant() in the ldap file. This is inconsistent and causes a warning on a fresh installation.

Note: I assume the problem occurred for gabrielvilareal, because an old version of phpmyfaq/config/constants_ldap.php has been used, specifying constants instead of strings. This typically happens as a consequence of an update where you keep the old version of the file. It happened for me as well.

[thorsten]

I will re-check this.