Skip to content

NO-REF scaledown + bugfix#3

Open
khanh-nguyen wants to merge 9 commits intothompsy:masterfrom
khanh-nguyen:NO-REF-scaledown-bugfix
Open

NO-REF scaledown + bugfix#3
khanh-nguyen wants to merge 9 commits intothompsy:masterfrom
khanh-nguyen:NO-REF-scaledown-bugfix

Conversation

@khanh-nguyen
Copy link
Copy Markdown

WIP

  • I had to reduce number of UEs to make it work on my machine.
  • Fix some hardcode parameters.
  • Make fading data path more generic.
  • Fix bug double accumulation of signal in UE.

@khanh-nguyen
Copy link
Copy Markdown
Author

@thompsy I'm not sure how to recalculate the numbers in the tests and if you want to scale down this way. But I just don't have resources to run the current settings.
It may take a while until the tests are updated, but if you have time, please review my PR.
Thanks.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious why did you use LOG.error instead of debug or info?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, never mind. Saw your logback settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants