Skip to content

fix: add missing lastParameter variable in TimeoutCancellationTokenAnalyzer #4956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
Feb 19, 2026
+3 −1
Merged

fix: add missing lastParameter variable in TimeoutCancellationTokenAnalyzer #4956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion TUnit.Analyzers/TimeoutCancellationTokenAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ private void AnalyzeSymbol(SymbolAnalysisContext context)
}
}

var lastParameter = parameters[parameters.Length - 1];

if (cancellationTokenIndex == -1)
{
// CancellationToken is not present at all
Expand All @@ -78,7 +80,7 @@ private void AnalyzeSymbol(SymbolAnalysisContext context)
// CancellationToken exists but is not the last parameter
context.ReportDiagnostic(
Diagnostic.Create(Rules.CancellationTokenMustBeLastParameter,
context.Symbol.Locations.FirstOrDefault())
parameters[cancellationTokenIndex].Locations.FirstOrDefault() ?? context.Symbol.Locations.FirstOrDefault())
);
}
}
Expand Down
Loading