Skip to content

fix: remove empty Dispose and fix nullability annotation #4920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
Feb 19, 2026
Merged

fix: remove empty Dispose and fix nullability annotation #4920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions TUnit.Engine/Services/EventReceiverOrchestrator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

namespace TUnit.Engine.Services;

internal sealed class EventReceiverOrchestrator : IDisposable
internal sealed class EventReceiverOrchestrator
{
private readonly EventReceiverRegistry _registry = new();
private readonly TUnitFrameworkLogger _logger;
Expand Down Expand Up @@ -547,8 +547,4 @@ public void InitializeTestCounts(IEnumerable<TestContext> allTestContexts)
}
}

public void Dispose()
{
// No longer need to dispose _registry - it no longer uses ReaderWriterLockSlim
}
}
2 changes: 1 addition & 1 deletion TUnit.Engine/Services/PropertyInjector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ public async Task InjectPropertiesIntoArgumentsAsync(
}

private async Task InjectPropertiesRecursiveAsync(
object instance,
object? instance,
ConcurrentDictionary<string, object?> objectBag,
MethodMetadata? methodMetadata,
TestContextEvents events,
Expand Down
Loading