Skip to content

feat: add NUnit FileAssert, DirectoryAssert, and ExpectedException support #4361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 7 commits into from
Jan 13, 2026
Merged

feat: add NUnit FileAssert, DirectoryAssert, and ExpectedException support #4361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0d41155
feat: add NUnit FileAssert, DirectoryAssert, and ExpectedException su…
thomhurst Jan 13, 2026
18eeea0
fix: add TODO comment warning about DirectoryAssert.AreEqual semantic…
thomhurst Jan 13, 2026
0ed12b8
feat: add FileInfo/DirectoryInfo assertions and simplify migration
thomhurst Jan 13, 2026
9cfaad8
feat: add DoesNotHaveSameContentAs for FileInfo assertion
thomhurst Jan 13, 2026
6f05273
fix: add Path.GetRelativePath polyfill for netstandard2.0
thomhurst Jan 13, 2026
7184c5b
chore: update public API snapshots for new FileInfo/DirectoryInfo ass…
thomhurst Jan 13, 2026
4ce827c
fix: resolve infinite recursion in GetRelativePath on .NET 6+
thomhurst Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
392 changes: 386 additions & 6 deletions TUnit.Analyzers.CodeFixers/NUnitMigrationCodeFixProvider.cs
View file
Open in desktop

Large diffs are not rendered by default.

355 changes: 355 additions & 0 deletions TUnit.Analyzers.Tests/NUnitMigrationAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3249,6 +3249,361 @@ public async Task TestMethod([Matrix(1, 2)] int a, [Matrix("x", "y")] string b)
);
}

[Test]
public async Task NUnit_FileAssert_Exists_Converted()
{
await CodeFixer.VerifyCodeFixAsync(
"""
using NUnit.Framework;

{|#0:public class MyClass|}
{
[Test]
public void TestMethod()
{
FileAssert.Exists("test.txt");
}
}
""",
Verifier.Diagnostic(Rules.NUnitMigration).WithLocation(0),
"""
using System.IO;
using System.Threading.Tasks;
using TUnit.Core;
using TUnit.Assertions;
using static TUnit.Assertions.Assert;
using TUnit.Assertions.Extensions;

public class MyClass
{
[Test]
public async Task TestMethod()
{
await Assert.That(File.Exists("test.txt")).IsTrue();
}
}
""",
ConfigureNUnitTest
);
}

[Test]
public async Task NUnit_FileAssert_DoesNotExist_Converted()
{
await CodeFixer.VerifyCodeFixAsync(
"""
using NUnit.Framework;

{|#0:public class MyClass|}
{
[Test]
public void TestMethod()
{
FileAssert.DoesNotExist("test.txt");
}
}
""",
Verifier.Diagnostic(Rules.NUnitMigration).WithLocation(0),
"""
using System.IO;
using System.Threading.Tasks;
using TUnit.Core;
using TUnit.Assertions;
using static TUnit.Assertions.Assert;
using TUnit.Assertions.Extensions;

public class MyClass
{
[Test]
public async Task TestMethod()
{
await Assert.That(File.Exists("test.txt")).IsFalse();
}
}
""",
ConfigureNUnitTest
);
}

[Test]
public async Task NUnit_FileAssert_AreEqual_Converted()
{
await CodeFixer.VerifyCodeFixAsync(
"""
using NUnit.Framework;

{|#0:public class MyClass|}
{
[Test]
public void TestMethod()
{
FileAssert.AreEqual("expected.txt", "actual.txt");
}
}
""",
Verifier.Diagnostic(Rules.NUnitMigration).WithLocation(0),
"""
using System.IO;
using System.Threading.Tasks;
using TUnit.Core;
using TUnit.Assertions;
using static TUnit.Assertions.Assert;
using TUnit.Assertions.Extensions;

public class MyClass
{
[Test]
public async Task TestMethod()
{
await Assert.That(new FileInfo("actual.txt")).HasSameContentAs(new FileInfo("expected.txt"));
}
}
""",
ConfigureNUnitTest
);
}

[Test]
public async Task NUnit_FileAssert_AreNotEqual_Converted()
{
await CodeFixer.VerifyCodeFixAsync(
"""
using NUnit.Framework;

{|#0:public class MyClass|}
{
[Test]
public void TestMethod()
{
FileAssert.AreNotEqual("expected.txt", "actual.txt");
}
}
""",
Verifier.Diagnostic(Rules.NUnitMigration).WithLocation(0),
"""
using System.IO;
using System.Threading.Tasks;
using TUnit.Core;
using TUnit.Assertions;
using static TUnit.Assertions.Assert;
using TUnit.Assertions.Extensions;

public class MyClass
{
[Test]
public async Task TestMethod()
{
await Assert.That(new FileInfo("actual.txt")).DoesNotHaveSameContentAs(new FileInfo("expected.txt"));
}
}
""",
ConfigureNUnitTest
);
}

[Test]
public async Task NUnit_DirectoryAssert_Exists_Converted()
{
await CodeFixer.VerifyCodeFixAsync(
"""
using NUnit.Framework;

{|#0:public class MyClass|}
{
[Test]
public void TestMethod()
{
DirectoryAssert.Exists("testDir");
}
}
""",
Verifier.Diagnostic(Rules.NUnitMigration).WithLocation(0),
"""
using System.IO;
using System.Threading.Tasks;
using TUnit.Core;
using TUnit.Assertions;
using static TUnit.Assertions.Assert;
using TUnit.Assertions.Extensions;

public class MyClass
{
[Test]
public async Task TestMethod()
{
await Assert.That(Directory.Exists("testDir")).IsTrue();
}
}
""",
ConfigureNUnitTest
);
}

[Test]
public async Task NUnit_DirectoryAssert_DoesNotExist_Converted()
{
await CodeFixer.VerifyCodeFixAsync(
"""
using NUnit.Framework;

{|#0:public class MyClass|}
{
[Test]
public void TestMethod()
{
DirectoryAssert.DoesNotExist("testDir");
}
}
""",
Verifier.Diagnostic(Rules.NUnitMigration).WithLocation(0),
"""
using System.IO;
using System.Threading.Tasks;
using TUnit.Core;
using TUnit.Assertions;
using static TUnit.Assertions.Assert;
using TUnit.Assertions.Extensions;

public class MyClass
{
[Test]
public async Task TestMethod()
{
await Assert.That(Directory.Exists("testDir")).IsFalse();
}
}
""",
ConfigureNUnitTest
);
}

[Test]
public async Task NUnit_DirectoryAssert_AreEqual_Converted()
{
await CodeFixer.VerifyCodeFixAsync(
"""
using NUnit.Framework;

{|#0:public class MyClass|}
{
[Test]
public void TestMethod()
{
DirectoryAssert.AreEqual("expectedDir", "actualDir");
}
}
""",
Verifier.Diagnostic(Rules.NUnitMigration).WithLocation(0),
"""
using System.IO;
using System.Threading.Tasks;
using TUnit.Core;
using TUnit.Assertions;
using static TUnit.Assertions.Assert;
using TUnit.Assertions.Extensions;

public class MyClass
{
[Test]
public async Task TestMethod()
{
await Assert.That(new DirectoryInfo("actualDir")).IsEquivalentTo(new DirectoryInfo("expectedDir"));
}
}
""",
ConfigureNUnitTest
);
}

[Test]
public async Task NUnit_ExpectedException_Converted()
{
await CodeFixer.VerifyCodeFixAsync(
"""
using System;
using NUnit.Framework;

public class MyClass
{
{|#0:[Test]|}
[ExpectedException(typeof(InvalidOperationException))]
public void TestMethod()
{
throw new InvalidOperationException();
}
}
""",
Verifier.Diagnostic(Rules.NUnitMigration).WithLocation(0),
"""
using System;
using System.Threading.Tasks;
using TUnit.Core;
using TUnit.Assertions;
using static TUnit.Assertions.Assert;
using TUnit.Assertions.Extensions;

public class MyClass
{
[Test]
public async Task TestMethod()
{
await Assert.ThrowsAsync<InvalidOperationException>(() =>
{
throw new InvalidOperationException();
});
}
}
""",
ConfigureNUnitTest
);
}

[Test]
public async Task NUnit_ExpectedException_With_Async_Code_Converted()
{
await CodeFixer.VerifyCodeFixAsync(
"""
using System;
using System.Threading.Tasks;
using NUnit.Framework;

public class MyClass
{
{|#0:[Test]|}
[ExpectedException(typeof(InvalidOperationException))]
public async Task TestMethod()
{
await Task.Delay(1);
throw new InvalidOperationException();
}
}
""",
Verifier.Diagnostic(Rules.NUnitMigration).WithLocation(0),
"""
using System;
using System.Threading.Tasks;
using TUnit.Core;
using TUnit.Assertions;
using static TUnit.Assertions.Assert;
using TUnit.Assertions.Extensions;

public class MyClass
{
[Test]
public async Task TestMethod()
{
await Assert.ThrowsAsync<InvalidOperationException>(async () =>
{
await Task.Delay(1);
throw new InvalidOperationException();
});
}
}
""",
ConfigureNUnitTest
);
}

private static void ConfigureNUnitTest(Verifier.Test test)
{
test.TestState.AdditionalReferences.Add(typeof(NUnit.Framework.TestAttribute).Assembly);
Expand Down
Loading
Loading