feat: add ConfigureThreadPool method to optimize parallel test execution

[thomhurst]

No description provided.

[claude]

Claude finished @thomhurst's task —— View job

---

Code Review

Todo List:

• Read and analyze the modified file TUnit.Engine/TUnitInitializer.cs
• Review changes against TUnit coding standards and guidelines
• Check for potential bugs and issues
• Evaluate performance implications
• Assess security concerns
• Review test coverage requirements
• Provide comprehensive feedback

Review Findings:

Overall Assessment: ✅ Good Addition with Minor Considerations

This PR adds a performance optimization for parallel test execution by configuring ThreadPool settings during initialization. The implementation is well-documented and follows TUnit's coding standards.

Code Quality & Best Practices

✅ Good:

• Follows modern C# syntax and TUnit's style guide
• Well-documented with clear comments explaining the purpose
• Consistent with existing code patterns in the file
• Method is properly scoped as private and follows naming conventions

Performance Considerations

✅ Excellent Performance Impact:

• Primary Benefit: Eliminates the default ~500ms thread injection delay for parallel test execution
• Smart Scaling: Uses Environment.ProcessorCount * 4 with a minimum of 32 threads
• Critical for TUnit: Given TUnit processes millions of tests daily, this optimization is highly valuable
• Timing: Called early in initialization (line 17) before test discovery, which is optimal

Potential Issues & Suggestions

🟡 Minor Considerations:

1. Global State Modification: ThreadPool.SetMinThreads() affects the entire application domain, not just TUnit tests. Consider documenting this behavior more prominently.

2. Resource Usage: The formula processorCount * 4 might be aggressive for resource-constrained environments. Consider making this configurable via command line options in the future.

3. Verification Logging: Consider adding debug logging to show the configured values for troubleshooting:

   // Optional: Add debug logging
   if (Logger?.IsEnabled(LogLevel.Debug) == true)
   {
       Logger.LogDebug($"Configured ThreadPool: {minWorkerThreads} worker threads, {minIocpThreads} IOCP threads");
   }

Security Concerns

✅ No Security Issues: The code only configures ThreadPool settings using safe, documented APIs.

Test Coverage Assessment

🟡 Test Coverage Needs:

• Missing: No tests found for TUnitInitializer.ConfigureThreadPool() method
• Recommendation: Add integration tests to verify:
  • ThreadPool settings are applied correctly
  • Performance improvement is measurable
  • User overrides work as documented

Suggested test approach:

[Test]
public void ConfigureThreadPool_SetsExpectedMinThreads()
{
    // Test that ThreadPool.GetMinThreads() returns expected values after initialization
}

[Test] 
public void ConfigureThreadPool_AllowsUserOverride()
{
    // Test that users can call ThreadPool.SetMinThreads() to override
}

Dual-Mode Implementation

✅ Not Required: This optimization applies to the engine initialization and doesn't need dual-mode implementation (source-gen vs reflection).

Documentation

✅ Well-Documented: The comments clearly explain the purpose and user override capability.

---

Recommendation: ✅ Approve with Suggestion

This is a valuable performance optimization that aligns with TUnit's "Performance First" principle. The implementation is solid and safe. Consider adding test coverage and debug logging in a follow-up PR.

---