Skip to content

Fix GitHub reporter test state handling by including ErrorTestNodeStateProperty in status checks #3142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2025
Merged

Fix GitHub reporter test state handling by including ErrorTestNodeStateProperty in status checks #3142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions TUnit.Engine/Reporters/GitHubReporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public Task AfterRunAsync(int exitCode, CancellationToken cancellation)

var failed = last.Where(x =>
x.Value.TestNode.Properties.AsEnumerable()
.Any(p => p is FailedTestNodeStateProperty)).ToArray();
.Any(p => p is FailedTestNodeStateProperty or ErrorTestNodeStateProperty)).ToArray();

var cancelled = last.Where(x =>
x.Value.TestNode.Properties.AsEnumerable().Any(p => p is CancelledTestNodeStateProperty)).ToArray();
Expand Down Expand Up @@ -174,16 +174,13 @@ public Task AfterRunAsync(int exitCode, CancellationToken cancellation)
var name = testNodeUpdateMessage.TestNode.DisplayName;

var passedProperty = testNodeUpdateMessage.TestNode.Properties.OfType<PassedTestNodeStateProperty>().FirstOrDefault();

if (passedProperty != null)
{
continue;
}

var stateProperty = testNodeUpdateMessage.TestNode.Properties.AsEnumerable().FirstOrDefault(p =>
p is FailedTestNodeStateProperty ||
p is SkippedTestNodeStateProperty ||
p is TimeoutTestNodeStateProperty ||
p is CancelledTestNodeStateProperty);
var stateProperty = testNodeUpdateMessage.TestNode.Properties.AsEnumerable().FirstOrDefault(p => p is TestNodeStateProperty);

var status = GetStatus(stateProperty);

Expand Down Expand Up @@ -241,6 +238,7 @@ private Task WriteFile(string contents)
private string GetDetails(IProperty? stateProperty, PropertyBag properties)
{
if (stateProperty is FailedTestNodeStateProperty
or ErrorTestNodeStateProperty
or TimeoutTestNodeStateProperty
or CancelledTestNodeStateProperty)
{
Expand Down Expand Up @@ -268,6 +266,8 @@ or TimeoutTestNodeStateProperty
{
FailedTestNodeStateProperty failedTestNodeStateProperty =>
failedTestNodeStateProperty.Exception?.ToString() ?? "Test failed",
ErrorTestNodeStateProperty errorTestNodeStateProperty =>
errorTestNodeStateProperty.Exception?.ToString() ?? "Test failed",
TimeoutTestNodeStateProperty timeoutTestNodeStateProperty => timeoutTestNodeStateProperty.Explanation,
CancelledTestNodeStateProperty => "Test was cancelled",
_ => null
Expand All @@ -279,6 +279,7 @@ private static string GetStatus(IProperty? stateProperty)
return stateProperty switch
{
CancelledTestNodeStateProperty => "Cancelled",
ErrorTestNodeStateProperty => "Failed",
FailedTestNodeStateProperty => "Failed",
InProgressTestNodeStateProperty => "In Progress (never finished)",
PassedTestNodeStateProperty => "Passed",
Expand Down
Loading