Don't overwrite LangVersion if set and check raise diagnostic error if level not high enough#2437
Conversation
…f level not high enough
This was referenced Jul 23, 2025
Youssef1313
reviewed
Jan 1, 2026
| [Generator] | ||
| public class LanguageVersionCheckGenerator : IIncrementalGenerator | ||
| { | ||
| public void Initialize(IncrementalGeneratorInitializationContext context) |
Contributor
There was a problem hiding this comment.
Looks to me like this shouldn't be a source generator at all. It should instead be a diagnostic analyzer.
Youssef1313
reviewed
Jan 1, 2026
| <TestingPlatformShowTestsFailure>true</TestingPlatformShowTestsFailure> | ||
| <TestingPlatformCaptureOutput>false</TestingPlatformCaptureOutput> | ||
| <LangVersion>latest</LangVersion> | ||
| <OutputType>Exe</OutputType> |
Contributor
There was a problem hiding this comment.
Unrelated to your PR. But setting OutputType in NuGet props/targets is very bad and should NOT be done. It should be on the user to set this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2426