-
-
Notifications
You must be signed in to change notification settings - Fork 114
Closed
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
Description
Empty Dispose in EventReceiverOrchestrator.cs (Lines 550-553)
public void Dispose() { /* No longer need to dispose... */ }Class implements IDisposable but has no cleanup logic. Should either remove the interface or document why it's retained.
Missing Nullability Annotations in PropertyInjector.cs
Methods like InjectPropertiesRecursiveAsync accept TestContextEvents events without ? nullability, but line 105 checks if (events == null). The contract is unclear — parameter should be marked nullable or validated with ArgumentNullException.
Suggested Fix
- Remove
IDisposablefromEventReceiverOrchestratorif no cleanup is needed - Add consistent nullability annotations to
PropertyInjectorparameters
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed