-
Notifications
You must be signed in to change notification settings - Fork 8
Fix work with queue arguments in queue_declare #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @manakao. As you can see here the Can you provide some examples where you have errors? |
thomasvargiu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes
When i want to use custom table options such as |
|
@manakao can you write a test? Do you need help for it? |
manakao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manakao can you write a test? Do you need help for it?
Yes, i write TestSetupFabric for BaseAmqp
thomasvargiu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Can you resolve my note? Then I'll merge it and tag a new release.
| $method->setAccessible(true); | ||
|
|
||
| return $method; | ||
| static::assertEquals($channel, $baseAmqp->getChannel()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a test, and I think we can remove this method because I don't see any usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a test, and I think we can remove this method because I don't see any usage.
Are you mean testSetChannel or getMethod ? If last it is already deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right! My mistake! Thanks.
|
Thank you @manakao. I tagged version |
|
@manakao I'm having problems with these changes. Are you using it? |
|
Reverted in 3.0.2 |
To work with queue arguments, we need to wrap arguments by \PhpAmqpLib\Wire\AMQPTable.
Exception will be: