Skip to content

Conversation

@manakao
Copy link
Contributor

@manakao manakao commented Sep 13, 2018

To work with queue arguments, we need to wrap arguments by \PhpAmqpLib\Wire\AMQPTable.
Exception will be:

PhpAmqpLib\Exception\AMQPOutOfRangeException

File:
vendor/php-amqplib/php-amqplib/PhpAmqpLib/Wire/AMQPAbstractCollection.php:417
Message:
AMQP-rabbit doesn't define data of type []

@thomasvargiu
Copy link
Owner

thomasvargiu commented Sep 15, 2018

Thanks @manakao.
In the master branch the minimum required version of php-amqplib is ^2.7 and I could merge it, but I think it's not a problem of this library.

As you can see here the php-amplib library should handle it.

Can you provide some examples where you have errors?
Can you write a test for it?

Copy link
Owner

@thomasvargiu thomasvargiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes

@manakao
Copy link
Contributor Author

manakao commented Dec 7, 2018

Can you provide some examples where you have errors?

When i want to use custom table options such as

'queue'                     => [
    'name'      => 'notification_delay_60',
    'arguments' => [
        'x-dead-letter-exchange' => 'notification',
        'x-message-ttl' => 60000, // 60 * 1000 ms
        'x-expires' => 70000,  // 70 * 1000 ms
    ],
],

@thomasvargiu
Copy link
Owner

@manakao can you write a test? Do you need help for it?

Copy link
Contributor Author

@manakao manakao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manakao can you write a test? Do you need help for it?

Yes, i write TestSetupFabric for BaseAmqp

Copy link
Owner

@thomasvargiu thomasvargiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Can you resolve my note? Then I'll merge it and tag a new release.

$method->setAccessible(true);

return $method;
static::assertEquals($channel, $baseAmqp->getChannel());
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a test, and I think we can remove this method because I don't see any usage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a test, and I think we can remove this method because I don't see any usage.

Are you mean testSetChannel or getMethod ? If last it is already deleted.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right! My mistake! Thanks.

@thomasvargiu thomasvargiu merged commit 4961528 into thomasvargiu:master Jun 24, 2019
@thomasvargiu
Copy link
Owner

Thank you @manakao. I tagged version 3.0.1

@thomasvargiu
Copy link
Owner

@manakao I'm having problems with these changes. Are you using it?

@thomasvargiu
Copy link
Owner

Reverted in 3.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants