Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: encode_colour() and _native() allow na_value #38

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Feature: encode_colour() and _native() allow na_value #38

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d212223
MAINT: Remove deprecated context() from tests
zeehio Sep 18, 2022
52a1dc9
REFACTOR: Encode colour input
zeehio Sep 18, 2022
8e87454
FEAT: encode colour accepts a list/data.frame of channels besides a m…
zeehio Sep 18, 2022
99a9c9a
TEST: Add unit test for encode_colour with list or data frame
zeehio Sep 18, 2022
52149d2
NEWS: Add entry for list of channels feature
zeehio Sep 18, 2022
69b2b7b
DOCUMENT: devtools::document()
zeehio Sep 18, 2022
90cd293
PERF: encode_native does not go through a character vector representa…
zeehio Sep 18, 2022
d69d32b
DOC: devtools::document()
zeehio Sep 18, 2022
4d2459b
Test native encoding
zeehio Sep 18, 2022
796297d
NEWS: Faster encode_native()
zeehio Sep 18, 2022
3f632b1
FEAT: encode_colour() and encode_native() accept a na_value
zeehio Sep 19, 2022
8eb78b6
TEST: Add tests for na_value in encode_*() functions
zeehio Sep 19, 2022
67aa7bb
DOC: devtools::document()
zeehio Sep 19, 2022
b855431
NEWS: Add entry for na_value support
zeehio Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
NEWS: Add entry for na_value support
  • Loading branch information
@zeehio
zeehio committed Sep 19, 2022
commit b855431ba55d3ba05f72d01ca63a500b55590902
7 changes: 6 additions & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,12 @@
a contiguous matrix anymore, but rather you can `list()` them (#36, @zeehio).

* `encode_native()` is faster now. It avoids going through an intermediate character
vector representation (#375, @zeehio).
vector representation (#37, @zeehio).

* `encode_colour()` and `encode_native()` accept a `na_value` argument to specify
a color that can be used as a fallback if the color to convert contains `NA`s
or it can not be represented in the RGB space. (#38, @zeehio)


# farver 2.1.1

Expand Down