-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: additional checks for card editor entities array #277
Conversation
This wouldn't result in any visual errors, but the console would get filled with `console.error()`
fix: revert changes unrelated to PR
Reverted the changes unrelated to the PR |
Can someone review and accept the PR, please? I am affected by the bug this causes. |
Hi @thomasloven may I ask what the current status is with this task please as it would be really useful to have this approved so that the UI becomes available in the excellent power flow card that @flixlix has created. Thanks. |
Hey @thomasloven same here, please have a look at it |
When will be merged? This is a great PR |
Any news on getting this merged? this will also help me with a similar issue |
I had to do some massaging offline to get this to merge. It's merged in e7405bf Thanks a lot! And I'm really sorry this has caused issues for you and that I've been so slow to respond. |
Thanks @thomasloven I have just updated and now I see the GUI and Power Card Plus. Super! |
This resolves my issue #275
Adds Additional checks in the editor. Checks if entities is actually an array before trying to do anything.