Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to always display alpha and fix vec4 alpha to always be float #233

Merged
merged 1 commit into from
Apr 12, 2018
Merged

Add option to always display alpha and fix vec4 alpha to always be float #233

merged 1 commit into from
Apr 12, 2018

Conversation

kroko
Copy link
Contributor

@kroko kroko commented Mar 31, 2018 •
edited
Loading

Just as the title says 😄

  • Currently when alpha is 1, it is not outputted -> Newly added settings toggle can force to always output alpha.
  • Currently when alpha is 1 and it is outputted it stays 1 which is a no go for vec4 -> thus this pull also addresses to always output float 1.0 in this case.

@thomaslindstrom thomaslindstrom merged commit 05d10d7 into thomaslindstrom:master Apr 12, 2018
@thomaslindstrom
Copy link
Owner

Looks good, @kroko. Thanks!

@thomaslindstrom
Copy link
Owner

7f95eb5

@kroko
Copy link
Contributor Author

kroko commented Apr 13, 2018

thanks for the merge!

@kroko kroko mentioned this pull request Jun 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kroko @thomaslindstrom