Align token source usage

thomasbraun1976 · May 2, 2021 · 6463e4c · 6463e4c
1 parent 83504ad
commit 6463e4c
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 18 deletions.
diff --git a/internal/charger/easee.go b/internal/charger/easee.go
@@ -65,7 +65,7 @@ func NewEasee(user, password, charger string, cache time.Duration) (*Easee, erro
 		return c, err
 	}
 
-	// replace transport client with authenticated client
+	// replace client transport with authenticated transport
 	c.Client.Transport = &oauth2.Transport{
 		Source: ts,
 		Base:   c.Client.Transport,

diff --git a/internal/vehicle/id/api.go b/internal/vehicle/id/api.go
@@ -35,14 +35,13 @@ const (
 
 // NewAPI creates a new vehicle
 func NewAPI(log *util.Logger, identity oauth2.TokenSource) *API {
-	helper := request.NewHelper(log)
-	helper.Client.Transport = &oauth2.Transport{
-		Source: identity,
-		Base:   helper.Transport,
+	v := &API{
+		Helper: request.NewHelper(log),
 	}
 
-	v := &API{
-		Helper: helper,
+	v.Client.Transport = &oauth2.Transport{
+		Source: identity,
+		Base:   v.Client.Transport,
 	}
 
 	return v

diff --git a/internal/vehicle/nissan.go b/internal/vehicle/nissan.go
@@ -82,10 +82,10 @@ func NewNissanFromConfig(other map[string]interface{}) (api.Vehicle, error) {
 
 	token, err := v.authFlow()
 	if err == nil {
-		// replace transport client with authenticated client
-		v.Helper.Client.Transport = &oauth2.Transport{
+		// replace client transport with authenticated transport
+		v.Client.Transport = &oauth2.Transport{
 			Source: oauth.RefreshTokenSource((*oauth2.Token)(&token), v),
-			Base:   v.Helper.Client.Transport,
+			Base:   v.Client.Transport,
 		}
 	}
 

diff --git a/internal/vehicle/vw/api.go b/internal/vehicle/vw/api.go
@@ -25,20 +25,19 @@ type API struct {
 }
 
 // NewAPI creates a new api client
-func NewAPI(log *util.Logger, identity *Identity, brand, country string) *API {
-	helper := request.NewHelper(log)
-	helper.Client.Transport = &oauth2.Transport{
-		Source: identity,
-		Base:   helper.Transport,
-	}
-
+func NewAPI(log *util.Logger, identity oauth2.TokenSource, brand, country string) *API {
 	v := &API{
-		Helper:  helper,
+		Helper:  request.NewHelper(log),
 		brand:   brand,
 		country: country,
 		baseURI: DefaultBaseURI,
 	}
 
+	v.Client.Transport = &oauth2.Transport{
+		Source: identity,
+		Base:   v.Client.Transport,
+	}
+
 	return v
 }