feat: profile part of the app #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuruyia
requested changes
Oct 27, 2023
front/src/pages/internal/profile/references/ReferencesUpdatePage.tsx
Outdated
Show resolved
Hide resolved
front/src/pages/internal/profile/references/ReferencesUpdatePage.tsx
Outdated
Show resolved
Hide resolved
front/src/store/slice/api.ts
Outdated
Collaborator
There was a problem hiding this comment.
Split this file into one API slice per endpoint group to avoid having a huge file:
- Availabilities
- Experiences
- References
- Evaluations
- Profile
- Jobs & Job categories
See an example here: https://redux-toolkit.js.org/rtk-query/usage/code-splitting
Also, please create dedicated DTO types for the builder.query/builder.mutation generic parameters (even if they are just aliases to the current types for now).
Collaborator
There was a problem hiding this comment.
I think there are some unwanted modifications in this file.
Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>
thomas-mauran
force-pushed
the
feat/front
branch
from
a3bed43 to
1cfed8d
Compare
Kuruyia
reviewed
Nov 8, 2023
Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>
Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>
Kuruyia
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Featuring