Skip to content

Conversation

@thomas-mauran
Copy link
Owner

  • joboffer list

@thomas-mauran thomas-mauran self-assigned this Nov 25, 2023
@Kuruyia Kuruyia added the enhancement New feature or request label Nov 25, 2023
Copy link
Collaborator

@Kuruyia Kuruyia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some modifications, otherwise LGTM!

About the styles of your components (see d39bd30):

  • Use the gap property instead of margins whenever possible : it helps decrease code size and enforce consistency
  • You tend to add unneeded (unstyled) <View> components
  • You put a margin in the container style of the JobOfferItem component : avoid enforcing stylistic choices at the item level - here, you should have put this margin at also better, because what you really wanted was margins on the entire content of the page)
  • Don't forget to add a <ScrollView> at the page level to be able to scroll - especially if you're rendering a list

@thomas-mauran thomas-mauran merged commit 26ef084 into main Nov 26, 2023
@Kuruyia Kuruyia deleted the front/job-offers branch December 1, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants