docs: definition of the service, mermaid for the infra and openapi link #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
thomas-mauran
commented
Nov 10, 2023
thomas-mauran
commented
- Archi graph
- Services
- Openapi link
Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>
Kuruyia
requested changes
Nov 11, 2023
Collaborator
Kuruyia
left a comment
Kuruyia
left a comment
There was a problem hiding this comment.
Overall this is a good start!
I think it's missing a few things:
- A section for the technologies that we use (GitHub CI, Kubernetes, NATS...)
- A section for detailing the pros and cons of the libraries and technologies that we use
added 2 commits
November 12, 2023 14:21
Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>
Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>
Owner
Author
Done 👍 |
Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>
thomas-mauran
force-pushed
the
docs/archi-report
branch
from
0b65e63 to
763b21a
Compare
Kuruyia
requested changes
Nov 13, 2023
Co-authored-by: Kuruyia <8174691+Kuruyia@users.noreply.github.com>
Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>
Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>
Kuruyia
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.