Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comment and add new ambiguous example #1665

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

StevellM
Copy link
Collaborator

Follows #1664

We can remove the comment now, I have checked what was needed. I found another ambiguous example in my data, so I added it.
While playing with data, I found a misbehaving argument check which did not take in account the case of genus enumeration in the non full rank case for binary form over QQ.

Copy link
Collaborator

@simonbrandhorst simonbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@simonbrandhorst simonbrandhorst enabled auto-merge (squash) October 29, 2024 07:58
@thofma
Copy link
Owner

thofma commented Oct 29, 2024

Can you add the example of the non-full rank lattices?

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.94%. Comparing base (bd5a960) to head (cde5b4a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1665      +/-   ##
==========================================
- Coverage   76.04%   75.94%   -0.10%     
==========================================
  Files         361      361              
  Lines      113532   113785     +253     
==========================================
+ Hits        86336    86417      +81     
- Misses      27196    27368     +172     
Files with missing lines Coverage Δ
src/QuadForm/Quad/GenusRep.jl 86.65% <100.00%> (ø)

... and 51 files with indirect coverage changes

@simonbrandhorst simonbrandhorst merged commit 2b1fd06 into thofma:master Oct 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants