Skip to content

Adapt to name printing changes in AA #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 10, 2024
Merged

Conversation

lgoettgens
Copy link
Contributor

@lgoettgens lgoettgens commented Feb 5, 2024

Refactors everything about name printing to only use the interface discussed in Nemocas/AbstractAlgebra.jl#1594 (and no longer any internals)

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Merging #1393 (e1725b1) into master (534937a) will increase coverage by 0.08%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1393      +/-   ##
==========================================
+ Coverage   70.56%   70.64%   +0.08%     
==========================================
  Files         351      351              
  Lines      111861   111852       -9     
==========================================
+ Hits        78936    79020      +84     
+ Misses      32925    32832      -93     
Files Coverage Δ
src/Hecke.jl 44.44% <ø> (ø)
src/NumFieldOrd/NfOrd/NfOrd.jl 85.52% <0.00%> (+0.21%) ⬆️
src/Misc/IJulia.jl 0.00% <0.00%> (ø)
src/GrpAb/ChainComplex.jl 0.00% <0.00%> (ø)

... and 36 files with indirect coverage changes

@lgoettgens
Copy link
Contributor Author

lgoettgens commented Feb 7, 2024

This needs oscar-system/Oscar.jl#3328 to be merged first.

@lgoettgens lgoettgens closed this Feb 7, 2024
@lgoettgens lgoettgens reopened this Feb 7, 2024
@thofma thofma merged commit a04cf97 into thofma:master Feb 10, 2024
@lgoettgens lgoettgens deleted the lg/show-name-2 branch February 10, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants