Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for Integer.jl #1351

Merged
merged 10 commits into from
Feb 20, 2024
Merged

Conversation

Sreevatsa2k
Copy link
Contributor

Adding tests for Integer.jl.

Copy link
Collaborator

@fieker fieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave it as it is, it shall be merged as soon as the tests pass.
However, please don't add the line-numbers: the first time s.o. works on the file in Misc, the number will change.
also, next time, the individual tests (@test ...) lines, should be indented (as all the other files)

@thofma
Copy link
Owner

thofma commented Jan 16, 2024

The file needs a newline

@fieker
Copy link
Collaborator

fieker commented Jan 16, 2024

then we can also address the rest

@thofma
Copy link
Owner

thofma commented Jan 19, 2024

The file is still missing a newline: See the small red circle at the bottom: https://github.com/thofma/Hecke.jl/pull/1351/files#diff-46dcf254ae59dd56207a99849760406fc71dab79d58a7aee8eb534a60eb88d34R18

test/Misc/Integer.jl Outdated Show resolved Hide resolved
@thofma
Copy link
Owner

thofma commented Jan 24, 2024

I think the last thing to do is adding a corresponding line in here: https://github.com/thofma/Hecke.jl/blob/master/test/Misc.jl

test/Misc/Integer.jl Outdated Show resolved Hide resolved
test/Misc/Integer.jl Outdated Show resolved Hide resolved
test/Misc/Integer.jl Outdated Show resolved Hide resolved
test/Misc/Integer.jl Outdated Show resolved Hide resolved
test/Misc/Integer.jl Outdated Show resolved Hide resolved
@thofma thofma marked this pull request as ready for review January 30, 2024 07:45
@fieker
Copy link
Collaborator

fieker commented Feb 19, 2024

unforutunately, you're PR is outdated, some functions names have changed and it needs to get adjusted.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Merging #1351 (eede88d) into master (961afd7) will decrease coverage by 3.57%.
Report is 48 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1351      +/-   ##
==========================================
- Coverage   74.29%   70.72%   -3.57%     
==========================================
  Files         351      350       -1     
  Lines      111805   111868      +63     
==========================================
- Hits        83069    79123    -3946     
- Misses      28736    32745    +4009     

see 129 files with indirect coverage changes

@thofma thofma merged commit 77b2fdf into thofma:master Feb 20, 2024
18 checks passed
fieker pushed a commit that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants