-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for Integer.jl #1351
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave it as it is, it shall be merged as soon as the tests pass.
However, please don't add the line-numbers: the first time s.o. works on the file in Misc, the number will change.
also, next time, the individual tests (@test ...) lines, should be indented (as all the other files)
The file needs a newline |
then we can also address the rest |
The file is still missing a newline: See the small red circle at the bottom: https://github.com/thofma/Hecke.jl/pull/1351/files#diff-46dcf254ae59dd56207a99849760406fc71dab79d58a7aee8eb534a60eb88d34R18 |
I think the last thing to do is adding a corresponding line in here: https://github.com/thofma/Hecke.jl/blob/master/test/Misc.jl |
unforutunately, you're PR is outdated, some functions names have changed and it needs to get adjusted. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1351 +/- ##
==========================================
- Coverage 74.29% 70.72% -3.57%
==========================================
Files 351 350 -1
Lines 111805 111868 +63
==========================================
- Hits 83069 79123 -3946
- Misses 28736 32745 +4009 |
Adding tests for Integer.jl.