added ref support for picker/datepicker components #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcabs3
changed the title
|
Wow, thank you for this. I'll check today an see if this is fine =) |
|
Thanks, Let me know if I missed something! I did notice that in RN 0.64 (I think) there is a bug with the internal lib you use (posted below). The way we were able to work around it was disabling the picker |
thodubois
reviewed
Oct 25, 2021
| } | ||
| onClose && onClose(); | ||
| } | ||
| // Only execute when show changes |
thodubois
approved these changes
Oct 25, 2021
|
Hello, this should be available on 0.3.11 =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I appreciate what you have done for this library.
I (and my team) are trying to setup the ability to use a ref with your picker components
We need it so a form can press next and automatically open the picker. This PR has been tested locally to give us the functionality. I hope you can review and version bump npm soon :) let me know if you have any questions