Pythonize/open ems #153
Open
Pythonize/open ems #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interface is more robust and user friendly. Did it only for some functions I am using.
Important
In
openEMS.SetBoundaryCondI changed the interface, instead of receiving a list with 6 elements, it receives the 6 elements as function arguments. Advantages:The conversion from any code running with the previous interface to the new interface should be straightforward:
becomes
which should be easy to do with a single find-and-replace
.SetBoundaryCond(→.SetBoundaryCond(*.All the rest I think should be backwards compatible.