Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set Velocity.x on number '0' during updatePosVel #834

Open
reps8 opened this issue Dec 19, 2023 · 3 comments
Open

Cannot set Velocity.x on number '0' during updatePosVel #834

reps8 opened this issue Dec 19, 2023 · 3 comments
Assignees
Labels

Comments

@reps8
Copy link

reps8 commented Dec 19, 2023

User Description

Type what you were trying to do here...

Error Title

TypeError

Error Message

Cannot create property 'x' on number '0'

Stack

TypeError: Cannot create property 'x' on number '0'
at ae.updatePosVel (https://www.keeptrack.space/app/js/main.41a3572822fe0794e242.js:1039:1232700)
at $.getSat (https://www.keeptrack.space/app/js/main.41a3572822fe0794e242.js:1039:1187509)
at Te.updateOrbitBuffer (https://www.keeptrack.space/app/js/main.41a3572822fe0794e242.js:1090:10493)
at Object.Z [as cb] (https://www.keeptrack.space/app/js/590.bd7312813e75d6e19dda.js:214:166)
at https://www.keeptrack.space/app/js/main.41a3572822fe0794e242.js:2:2060534
at Array.forEach ()
at Object.updateLoop (https://www.keeptrack.space/app/js/main.41a3572822fe0794e242.js:2:2060520)
at lt.update (https://www.keeptrack.space/app/js/main.41a3572822fe0794e242.js:1512:114366)
at ct.update_ (https://www.keeptrack.space/app/js/main.41a3572822fe0794e242.js:1565:5625)
at ct.gameLoop (https://www.keeptrack.space/app/js/main.41a3572822fe0794e242.js:1512:117356)

thkruz added a commit that referenced this issue Dec 20, 2023
@thkruz thkruz self-assigned this Dec 20, 2023
@thkruz thkruz added the Bug label Dec 20, 2023
@thkruz thkruz added this to the Stable Orbits (Version 8.3) milestone Dec 20, 2023
@thkruz thkruz changed the title n0 Cannot set Velocity.x on number '0' during updatePosVel Dec 20, 2023
@thkruz
Copy link
Owner

thkruz commented Dec 20, 2023

I added a check for this situation in 30ccd82. Can you explain more details about what you were doing when this happened? It seems like you were either hovering over a dot or recently selected one. I'd ideally like to fix the cause of this error vs just catching it when it happens.

@thkruz
Copy link
Owner

thkruz commented Mar 30, 2024

There is currently a reset happening at the beginning of this method to ensure velocity was not incorrectly set to 0. Yet I am still getting bug reports saying velocity was set to 0 later on when an attempt was made to set the x value. I am going to update the bug reporter to include details about the version of KeepTrack that is running. It is possible that older versions are being used somewhere.

@thkruz
Copy link
Owner

thkruz commented Aug 15, 2024

Premade missile simulations were one of the culprits. I fixed that scenario, and they may have been the only issue, but will leave the velocity check in place until I rule out other scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants