Skip to content

Conversation

@localpcguy
Copy link
Contributor

fixes #41

@localpcguy
Copy link
Contributor Author

cc: @thisissoon - we are upgrading to Angular v10 and this is giving us a warning

jamesjwarren
jamesjwarren previously approved these changes Aug 4, 2020
Copy link
Member

@jamesjwarren jamesjwarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for updating this, looks great 👍
If you can rebase or merge it with the latest changes on master I can get this merged.

@localpcguy
Copy link
Contributor Author

I rebased master, had to rebuild the yarn lock file. And the references in the polyfills file were incorrect for the latest version. So there is some slight changes and 1 new commit to look at.

@MollardMichael
Copy link

Hello,

The lint failed because it failed to find stylelint. I failed to find the issue. yarn is run before testing and the package.json does include styleling. Could you try rerunning it ?

@localpcguy
Copy link
Contributor Author

@MollardMichael were you asking me to do something, or @jamesjwarren?

@localpcguy
Copy link
Contributor Author

@MollardMichael or @jamesjwarren (not sure who to ping, sorry) - we are now upgrading to Angular v11 now and are hoping this can be merged (potentially with an update to allow v11 also). What needs to be done to make that happen?

@jamesjwarren
Copy link
Member

Hi @localpcguy, it looks like there were some linting issues causing the CI test stage to fail, looks like these were possibly caused by prettier preset configs being updated as they're present on master as well. I've resolved the issues on master so rebasing this should now hopefully pass CI. Then I'm happy to merge this and the V11 work, thanks for updating!

@jamesjwarren jamesjwarren merged commit e3ce477 into thisissoon:master Feb 22, 2021
@localpcguy
Copy link
Contributor Author

Does this need an npm deployment? Looks like these changes may not be in the 4.2.2 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doesnt work with angular 10

3 participants