-
Notifications
You must be signed in to change notification settings - Fork 23
Update for Angular V10 #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc: @thisissoon - we are upgrading to Angular v10 and this is giving us a warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for updating this, looks great 👍
If you can rebase or merge it with the latest changes on master I can get this merged.
|
I rebased master, had to rebuild the yarn lock file. And the references in the polyfills file were incorrect for the latest version. So there is some slight changes and 1 new commit to look at. |
|
Hello, The lint failed because it failed to find stylelint. I failed to find the issue. yarn is run before testing and the package.json does include styleling. Could you try rerunning it ? |
|
@MollardMichael were you asking me to do something, or @jamesjwarren? |
|
@MollardMichael or @jamesjwarren (not sure who to ping, sorry) - we are now upgrading to Angular v11 now and are hoping this can be merged (potentially with an update to allow v11 also). What needs to be done to make that happen? |
|
Hi @localpcguy, it looks like there were some linting issues causing the CI test stage to fail, looks like these were possibly caused by prettier preset configs being updated as they're present on master as well. I've resolved the issues on master so rebasing this should now hopefully pass CI. Then I'm happy to merge this and the V11 work, thanks for updating! |
BREAKING CHANGE: requires Angular v10
…10 upgrade relates to thisissoon#41
…ctory-loader (deprecated)
5cea5ff to
ef09fe0
Compare
|
Does this need an npm deployment? Looks like these changes may not be in the 4.2.2 version. |
fixes #41