perf(InViewport): use intersection observer to calculate inviewport state #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoparearyee
force-pushed
the
perf/intersection-observer
branch
4 times, most recently
from
b01dfb5 to
eb12cfc
Compare
…tate Replace custom logic to calculate `InViewport` status for native `IntersectionObserver` API to improve performance and clean up code BREAKING CHANGE: Removed `forRoot` method in module which is no longer required for `AppBrowserModule`. Replaced with `forServer` method for `AppServerModule`. Removed debounce feature and rxjs dependancy to leave implementation up to the consumer of the library. This reduces bundle size if debounce feature is not being used. Updated inviewport classes to `sn-inviewport--in` and `sn-inviewport--out` to match SOON styleguide
edoparearyee
force-pushed
the
perf/intersection-observer
branch
from
eb12cfc to
e5249aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace custom logic to calculate
InViewportstatus for nativeIntersectionObserverAPI to improveperformance and clean up code
BREAKING CHANGE: Removed
forRootmethod in module which is no longer required forAppBrowserModule. Replaced withforServermethod forAppServerModule. Removed debounce feature and rxjs dependancy to leave implementation up to the consumer of the library. This reduces bundle size if debounce feature is not being used. Updated inviewport classes tosn-inviewport--inandsn-inviewport--outto match SOON styleguide