Premier puzzles downloader #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for #115.
New file premierdownloader.py implements a class based on CrosswordCompilerDownloader with 3 subclasses for the individual puzzle sources (Premier, Sheffer, Joseph). All three can accept 'latest' as well as --date input. Proper checks for whether the puzzle is available that day (Premier is Sunday only, while Sheffer and Joseph are all but Sunday).
I've tested various dates for both positive and negative reactions.
Based on our discussion in the issue thread, you might have to adjust the import statement to work in your environment. This works for me on Mac and Windows under VS Code.