Fix typing error in Parser #568
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ber of a class or interface
Author
|
@woutervanbakel mentioning you for visibility |
Collaborator
|
@mendrixsebas Thanks! Looks like the tests depend on the old implicit behavior, so we might run into the same on our side. Luckily it’ll fail at build time, not runtime. I think I can merge this once you fixed the unit tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get this error when compiling our project when we import easy:
Fix error TS2526: A 'this' type is available only in a non-static member of a class or interfaceThis forces us to add
"skipLibCheck": trueto our tsconfig.json compilerOptions, which we rather not do.This PR fixes the typing.