rsync just deleted half of my files

[jpastuszek]

I had Delete option checked in User settings and empty Remote so I can set it up per Workspace. I run Rsync on unconfigured workspace (empty Remote) and got this command running:

> rsync -rlptzv --progress --delete --exclude=.git --exclude=.vscode --exclude=target /Users/xxx/Documents/myproject/ / 

Guess what happened... luckily Mac has Time Machine...

Can you make sure Rsync does not run when Remote is empty and perhaps double check it is not running against /, please.

[thisboyiscrazy]

It should thow an error about remote not being set. Can you post you settings. Thanks.

[jgreat]

Can we get a bump on this issue, its pretty critical. I just destroyed my laptop thanks to this bug.

[jgreat]

Settings were something like:

"sync-rsync.sites": [
  {
    "remotePath": ""
  }
],
"sync-rsync.delete": true,
"sync-rsync.onSave": true

OS: Ubuntu 21.04
vscode: 1.62 (ish)

[jgreat]

vscode-rsync/src/Config.ts

Line 126 in 90ae7c4

if(undefined != site.remotePath && site.remotePath[site.remotePath.length - 1] != '/') site.remotePath += '/';

Is the culprit. Since "" does not equal null, you're defaulting to /. 😢