Adding 'isOptionSelected' prop #70
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I have also made it so that the onChange is not triggered each time '_value' changes as this may not be desired in many cases. I have a use case where I prompt the user asking whether they want to continue with the change, so in this case each time I load on to the page I was hit with the prompt even though I didn't intend to change the selection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added support for 'isOptionSelected' prop.
Please review this and let me know if there are any issues. I am need of this feature on my project.
Also please let me know if there are any unit tests or some way to test out all these changes thoroughly.
I have tested it on my project and its working on there.