Eth <> Wei + ERC20 Formatting functions for Utils.cs #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this isn't done: 1) some errors could never be handled on the unity end and break the app 2) returning "default" may be confused with an actual result Best bet is to throw so the task handler can check if task is faulted and handle as they wish.
|
Ok this should be good now |
Assets/Thirdweb/Scripts/Utils.cs
Outdated
| { | ||
| BigInteger weiBigInt = 0; | ||
| if (!BigInteger.TryParse(wei, out weiBigInt)) | ||
| return "INVALID_ARGUMENTS"; |
There was a problem hiding this comment.
probably want to throw here instead no?
There was a problem hiding this comment.
Up to you, wasn't sure what's best
Assets/Thirdweb/Scripts/Utils.cs
Outdated
| if (!BigInteger.TryParse(wei, out weiBigInt)) | ||
| return "INVALID_ARGUMENTS"; | ||
| double eth = (double)weiBigInt / DECIMALS_18; | ||
| return eth.ToString(); |
There was a problem hiding this comment.
how about just calling FormatERC20 here? that way we can expose decimalsToDisplay as an optional param on ToEth too which is super useful
|
Here we go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToWei, ToEth and FormatERC20 functions added.