Skip to content

[TOOL-4687] Dashboard: Show Special Price UI in claim tokens card #7284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Jun 5, 2025


PR-Codex overview

This PR focuses on improving the RecentTransfers and ClaimTokenCardUI components by refining state management, updating conditional rendering, and introducing a new TokenPrice component for better display of pricing information.

Detailed summary

  • Removed unused state hasFetchedOnce from RecentTransfers.
  • Changed the condition for the disabled attribute in the Button component.
  • Simplified isPending logic in RecentTransfersUI.
  • Introduced publicPrice object to streamline price data handling in ClaimTokenCardUI.
  • Added TokenPrice component for better price display with strikethrough functionality.
  • Enhanced conditional rendering for price information to include tooltips and special pricing indicators.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Jun 5, 2025

⚠️ No Changeset found

Latest commit: a5cd664

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jun 5, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jun 5, 2025
Copy link
Member Author

MananTank commented Jun 5, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

vercel bot commented Jun 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2025 6:52pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jun 5, 2025 6:52pm
login ⬜️ Skipped (Inspect) Jun 5, 2025 6:52pm
thirdweb_playground ⬜️ Skipped (Inspect) Jun 5, 2025 6:52pm
wallet-ui ⬜️ Skipped (Inspect) Jun 5, 2025 6:52pm

@vercel vercel bot temporarily deployed to Preview – login June 5, 2025 12:58 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 5, 2025 12:58 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 5, 2025 12:58 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 5, 2025 12:58 Inactive
@MananTank MananTank changed the title [TOOL-4886] Dashboard: Show Remaining supply progress bar ui in claim tokens card [TOOL-4886] Dashboard: Show Special Price UI in claim tokens card Jun 5, 2025
@MananTank MananTank marked this pull request as ready for review June 5, 2025 12:58
@MananTank MananTank requested review from a team as code owners June 5, 2025 12:58
@MananTank MananTank changed the title [TOOL-4886] Dashboard: Show Special Price UI in claim tokens card [TOOL-4687] Dashboard: Show Special Price UI in claim tokens card Jun 5, 2025
Copy link

linear bot commented Jun 5, 2025

Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.58%. Comparing base (05f65ec) to head (a5cd664).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7284   +/-   ##
=======================================
  Coverage   55.58%   55.58%           
=======================================
  Files         909      909           
  Lines       58670    58670           
  Branches     4158     4158           
=======================================
  Hits        32609    32609           
  Misses      25954    25954           
  Partials      107      107           
Flag Coverage Δ
packages 55.58% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jun 5, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.57 KB (0%) 1.3 s (0%) 186 ms (+131.34% 🔺) 1.5 s
thirdweb (cjs) 345.55 KB (0%) 7 s (0%) 649 ms (+12.97% 🔺) 7.6 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 60 ms (+1287.29% 🔺) 174 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 13 ms (+618.26% 🔺) 23 ms
thirdweb/react (minimal + tree-shaking) 19.56 KB (0%) 392 ms (0%) 61 ms (+346.98% 🔺) 452 ms

@MananTank MananTank marked this pull request as draft June 5, 2025 13:04
@MananTank MananTank force-pushed the 06-05-dashboard_add_supply_remaining_progress_in_asset_page_claim_tokens_card branch from 91b4cac to f12be98 Compare June 5, 2025 13:22
@MananTank MananTank force-pushed the 06-05-_tool-4886_dashboard_show_remaining_supply_progress_bar_ui_in_claim_tokens_card branch from ed901d9 to 15230ae Compare June 5, 2025 13:22
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 5, 2025 13:22 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 5, 2025 13:22 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 5, 2025 13:22 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 5, 2025 13:22 Inactive
@MananTank MananTank marked this pull request as ready for review June 5, 2025 13:22
Copy link
Contributor

graphite-app bot commented Jun 5, 2025

Merge activity

)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on improving the `RecentTransfers` and `ClaimTokenCardUI` components in a React application by refining state management, simplifying logic, and enhancing UI elements.

### Detailed summary
- Removed `hasFetchedOnce` state in `RecentTransfers`.
- Changed condition for disabling the button in `RecentTransfersUI`.
- Simplified logic for claim parameters in `ClaimTokenCardUI`.
- Introduced `TokenPrice` component to handle price display.
- Added tooltip for special pricing indication.
- Adjusted UI elements for better clarity and organization.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 06-05-dashboard_add_supply_remaining_progress_in_asset_page_claim_tokens_card branch from f12be98 to 05f65ec Compare June 5, 2025 18:44
@graphite-app graphite-app bot force-pushed the 06-05-_tool-4886_dashboard_show_remaining_supply_progress_bar_ui_in_claim_tokens_card branch from 15230ae to a5cd664 Compare June 5, 2025 18:44
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 5, 2025 18:44 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 5, 2025 18:44 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 5, 2025 18:44 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 5, 2025 18:44 Inactive
Base automatically changed from 06-05-dashboard_add_supply_remaining_progress_in_asset_page_claim_tokens_card to main June 5, 2025 18:52
@graphite-app graphite-app bot merged commit a5cd664 into main Jun 5, 2025
22 checks passed
@graphite-app graphite-app bot deleted the 06-05-_tool-4886_dashboard_show_remaining_supply_progress_bar_ui_in_claim_tokens_card branch June 5, 2025 18:53
@vercel vercel bot temporarily deployed to Production – thirdweb_playground June 5, 2025 18:53 Inactive
@vercel vercel bot temporarily deployed to Production – login June 5, 2025 18:53 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui June 5, 2025 18:53 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 June 5, 2025 18:53 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants