fix: handle short proxyStorage in getBeaconFromStorageSlot

[catalyst17]

---

PR-Codex overview

This PR updates the logic in the resolveImplementation.ts file to ensure that the function returns undefined if the proxyStorage length is less than 40 characters, enhancing error handling.

Detailed summary

• Added a check to ensure proxyStorage.length is at least 40 before returning the sliced value.
• If proxyStorage is shorter than 40 characters, the function now returns undefined.
• Maintained the existing error handling with a try-catch block.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of storage slot values to prevent errors when the data is shorter than expected.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 5, 2025 11:29am
login	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 5, 2025 11:29am
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 5, 2025 11:29am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 5, 2025 11:29am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 5, 2025 11:29am

[changeset-bot]

⚠️ No Changeset found

Latest commit: 0520ad0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The function getBeaconFromStorageSlot in the code was updated to include a check ensuring that the input string has at least 40 characters before extracting a substring. If the condition is not met, the function now returns undefined instead of an invalid value. No changes were made to exported or public entity declarations.

Changes

File	Change Summary
packages/thirdweb/src/utils/bytecode/resolveImplementation.ts	Added length check in getBeaconFromStorageSlot before substring extraction; returns undefined if input is too short.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant getBeaconFromStorageSlot

    Caller->>getBeaconFromStorageSlot: Call with proxyStorage
    alt proxyStorage length >= 40
        getBeaconFromStorageSlot-->>Caller: Return last 40 chars (with "0x" prefix)
    else proxyStorage length < 40 or error
        getBeaconFromStorageSlot-->>Caller: Return undefined
    end

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a87446a and 0520ad0.

📒 Files selected for processing (1)

• packages/thirdweb/src/utils/bytecode/resolveImplementation.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: E2E Tests (pnpm, esbuild)
• GitHub Check: E2E Tests (pnpm, webpack)
• GitHub Check: Build Packages
• GitHub Check: Unit Tests
• GitHub Check: E2E Tests (pnpm, vite)
• GitHub Check: Size
• GitHub Check: Lint Packages
• GitHub Check: Analyze (javascript)

🔇 Additional comments (1)

packages/thirdweb/src/utils/bytecode/resolveImplementation.ts (1)

113-116: Good fix for preventing double "0x" prefix issue.

This change correctly prevents a bug where short proxyStorage strings would result in malformed addresses with double "0x" prefixes. The length check ensures that slice(-40) will extract clean hex digits.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[catalyst17]

• fix: handle short proxyStorage in getBeaconFromStorageSlot #7281 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• merge-queue - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	62.57 KB (0%)	1.3 s (0%)	114 ms (+151.81% 🔺)	1.4 s
thirdweb (cjs)	345.55 KB (+0.05% 🔺)	7 s (+0.05% 🔺)	331 ms (+10.62% 🔺)	7.3 s
thirdweb (minimal + tree-shaking)	5.7 KB (0%)	114 ms (0%)	36 ms (+1106.52% 🔺)	150 ms
thirdweb/chains (tree-shaking)	531 B (0%)	11 ms (0%)	18 ms (+2351.65% 🔺)	28 ms
thirdweb/react (minimal + tree-shaking)	19.56 KB (0%)	392 ms (0%)	44 ms (+641.9% 🔺)	435 ms

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.58%. Comparing base (a87446a) to head (0520ad0).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...irdweb/src/utils/bytecode/resolveImplementation.ts	50.00%	2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7281   +/-   ##
=======================================
  Coverage   55.57%   55.58%           
=======================================
  Files         909      909           
  Lines       58667    58670    +3     
  Branches     4158     4163    +5     
=======================================
+ Hits        32606    32613    +7     
+ Misses      25954    25950    -4     
  Partials      107      107           

Flag	Coverage Δ
packages	55.58% <50.00%> (+<0.01%)	⬆️

Files with missing lines	Coverage Δ
...irdweb/src/utils/bytecode/resolveImplementation.ts	79.13% <50.00%> (-1.02%)	⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.