Skip to content

[Dashboard] Add Sophon testnet to custom claim amounts #7280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jun 5, 2025


PR-Codex overview

This PR introduces a new claim amount for the Sophon testnet in the claim-amount.ts file while retaining the existing claim amount for Aleph Zero.

Detailed summary

  • Added a new claim amount for the Sophon testnet: 531050104: 5.
  • Retained the existing claim amount for Aleph Zero: 0.1.
  • Defined a default claim amount of 0.01.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features
    • Added support for the Sophon testnet, allowing users to claim a specific amount (5) from the faucet when using this network.

Copy link

vercel bot commented Jun 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2025 9:56am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jun 5, 2025 9:56am
login ⬜️ Skipped (Inspect) Jun 5, 2025 9:56am
thirdweb_playground ⬜️ Skipped (Inspect) Jun 5, 2025 9:56am
wallet-ui ⬜️ Skipped (Inspect) Jun 5, 2025 9:56am

@vercel vercel bot temporarily deployed to Preview – login June 5, 2025 09:49 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 5, 2025 09:49 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 5, 2025 09:49 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 5, 2025 09:49 Inactive
Copy link

changeset-bot bot commented Jun 5, 2025

⚠️ No Changeset found

Latest commit: 7a6decb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jun 5, 2025

Walkthrough

A new entry for the Sophon testnet, identified by chain ID 531050104 and a claim amount of 5, was added to the custom claim amounts mapping in the testnet faucet claim logic. The function for retrieving claim amounts remains unchanged and now supports this new testnet.

Changes

File(s) Change Summary
.../api/testnet-faucet/claim/claim-amount.ts Added Sophon testnet (chain ID 531050104) with claim amount 5 to custom claim amounts mapping.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant FaucetAPI

    User->>FaucetAPI: Request claim amount (provide chain ID)
    FaucetAPI->>FaucetAPI: Lookup chain ID in customClaimAmounts
    alt Chain ID is 531050104 (Sophon)
        FaucetAPI-->>User: Return claim amount 5
    else Other chain ID
        FaucetAPI-->>User: Return corresponding or default claim amount
    end
Loading

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jun 5, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.57%. Comparing base (a87446a) to head (7a6decb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7280   +/-   ##
=======================================
  Coverage   55.57%   55.57%           
=======================================
  Files         909      909           
  Lines       58667    58667           
  Branches     4158     4158           
=======================================
  Hits        32606    32606           
  Misses      25954    25954           
  Partials      107      107           
Flag Coverage Δ
packages 55.57% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges marked this pull request as ready for review June 5, 2025 09:52
@joaquim-verges joaquim-verges requested review from a team as code owners June 5, 2025 09:52
Copy link
Contributor

github-actions bot commented Jun 5, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.57 KB (0%) 1.3 s (0%) 185 ms (+119.65% 🔺) 1.5 s
thirdweb (cjs) 345.38 KB (0%) 7 s (0%) 568 ms (-6.82% 🔽) 7.5 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 32 ms (+535.02% 🔺) 146 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 17 ms (+881.53% 🔺) 27 ms
thirdweb/react (minimal + tree-shaking) 19.56 KB (0%) 392 ms (0%) 79 ms (+411.43% 🔺) 470 ms

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apps/dashboard/src/app/(app)/api/testnet-faucet/claim/claim-amount.ts (1)

6-7: Add unit test for new mapping
Please include a unit test to verify that getFaucetClaimAmount(531050104) returns 5.

Do you want me to generate the test snippet?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a87446a and 7a6decb.

📒 Files selected for processing (1)
  • apps/dashboard/src/app/(app)/api/testnet-faucet/claim/claim-amount.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Size
🔇 Additional comments (1)
apps/dashboard/src/app/(app)/api/testnet-faucet/claim/claim-amount.ts (1)

6-7: Approve Sophon testnet entry
The addition of chain ID 531050104 with a claim amount of 5 is correct and aligns with the new Sophon testnet support.

@joaquim-verges joaquim-verges merged commit 5c1db8b into main Jun 5, 2025
27 checks passed
@joaquim-verges joaquim-verges deleted the _Dashboard_Add_Sophon_testnet_to_custom_claim_amounts branch June 5, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant