Skip to content

fix: invalid handling of ISO time in RPC graphs #7279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Jun 5, 2025

[Dashboard] Fix: Remove 'Z' suffix from date strings in usage graphs

Notes for the reviewer

This PR removes the 'Z' suffix that was being appended to date strings in the count and rate graphs on the team usage page. The date values are now passed directly without modification.

How to test

Check that the count and rate graphs on the team usage page display dates correctly without timezone issues.

Summary by CodeRabbit

  • Bug Fixes
    • Improved date handling in usage and rate graphs to ensure more accurate display of time information.

Copy link

vercel bot commented Jun 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2025 9:07am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jun 5, 2025 9:07am
login ⬜️ Skipped (Inspect) Jun 5, 2025 9:07am
thirdweb_playground ⬜️ Skipped (Inspect) Jun 5, 2025 9:07am
wallet-ui ⬜️ Skipped (Inspect) Jun 5, 2025 9:07am

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 5, 2025 09:00 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 5, 2025 09:00 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 5, 2025 09:00 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 5, 2025 09:00 Inactive
Copy link

changeset-bot bot commented Jun 5, 2025

⚠️ No Changeset found

Latest commit: 09239dc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jun 5, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The changes update the transformation of the time property in data passed to the ThirdwebAreaChart component in two files. The appended "Z" UTC suffix is removed, and the date string is now assigned directly to time. No other logic or component interface was modified.

Changes

File(s) Change Summary
.../usage/rpc/components/count-graph.tsx
.../usage/rpc/components/rate-graph.tsx
Updated mapping of time property by removing appended "Z" from date

Suggested labels

Dashboard


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9493fda and 09239dc.

📒 Files selected for processing (2)
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/usage/rpc/components/count-graph.tsx (1 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/usage/rpc/components/rate-graph.tsx (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@arcoraven arcoraven marked this pull request as ready for review June 5, 2025 09:00
@arcoraven arcoraven requested review from a team as code owners June 5, 2025 09:00
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jun 5, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@arcoraven arcoraven added the merge-queue Adds the pull request to Graphite's merge queue. label Jun 5, 2025
Copy link
Contributor Author

Merge activity

  • Jun 5, 9:01 AM UTC: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@arcoraven arcoraven merged commit a87446a into main Jun 5, 2025
21 of 23 checks passed
@arcoraven arcoraven deleted the ph/06-05-fix_invalid_handling_of_iso_time_in_rpc_graphs branch June 5, 2025 09:01
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.57%. Comparing base (9493fda) to head (09239dc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7279   +/-   ##
=======================================
  Coverage   55.57%   55.57%           
=======================================
  Files         909      909           
  Lines       58667    58667           
  Branches     4158     4158           
=======================================
  Hits        32606    32606           
  Misses      25954    25954           
  Partials      107      107           
Flag Coverage Δ
packages 55.57% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jun 5, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.57 KB (0%) 1.3 s (0%) 178 ms (+126.35% 🔺) 1.5 s
thirdweb (cjs) 345.38 KB (0%) 7 s (0%) 609 ms (+0.91% 🔺) 7.6 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 49 ms (+989.03% 🔺) 163 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 25 ms (+1300.01% 🔺) 35 ms
thirdweb/react (minimal + tree-shaking) 19.56 KB (0%) 392 ms (0%) 60 ms (+419.49% 🔺) 451 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant