Skip to content

[Dashboard] Fix peak rate date formatting with error handling #7271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

[Dashboard] Fix peak rate date formatting with error handling #7271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 28 additions & 11 deletions apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/usage/rpc/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { getTeamBySlug } from "@/api/team";
import { getLast24HoursRPCUsage } from "@/api/usage/rpc";
import { Alert, AlertDescription, AlertTitle } from "@/components/ui/alert";
import { Card, CardContent, CardHeader, CardTitle } from "@/components/ui/card";
import { format } from "date-fns";
import { format, parseISO } from "date-fns";
import {
AlertTriangleIcon,
CheckCircleIcon,
Expand Down Expand Up @@ -63,6 +63,23 @@ export default async function RPCUsage(props: {
Number(totalCounts.rateLimitedCount) +
Number(totalCounts.overageCount);

const peakRateDate = (() => {
if (peakRate.date) {
try {
// treat peakRate.date as UTC
const date = peakRate.date.endsWith("Z")
? parseISO(peakRate.date)
: // force the timestamp to be in UTC
parseISO(`${peakRate.date}Z`);
return format(date, "MMM d, HH:mm");
} catch (e) {
console.error("Error parsing peak rate date", peakRate.date, e);
return null;
}
}
return null;
})();

return (
<div className="container mx-auto space-y-8 py-6">
<div className="flex flex-col gap-2">
Expand Down Expand Up @@ -113,9 +130,7 @@ export default async function RPCUsage(props: {
</div>
<p className="mt-1 text-muted-foreground text-xs">
<ClockIcon className="mr-1 inline h-3 w-3" />
{peakRate.date
? format(new Date(`${peakRate.date}Z`), "MMM d, HH:mm")
: "No Requests in last 24 hours"}
{peakRateDate ? peakRateDate : "No Requests in last 24 hours"}
</p>
</CardContent>
</Card>
Expand All @@ -134,12 +149,14 @@ export default async function RPCUsage(props: {
<CheckCircleIcon className="mr-1 h-3 w-3 text-green-500" />
<span>
{/* we count both included and overage as included */}
{(
((Number(totalCounts.includedCount) +
Number(totalCounts.overageCount)) /
Number(totalRequests)) *
100
).toFixed(1)}
{totalRequests === 0
? "0.0"
: (
((Number(totalCounts.includedCount) +
Number(totalCounts.overageCount)) /
Number(totalRequests)) *
100
).toFixed(1)}
% successful requests
</span>
</div>
Expand All @@ -159,7 +176,7 @@ export default async function RPCUsage(props: {
<span>
{/* if there are no requests, we show 100% success rate */}
{totalRequests === 0
? "100"
? "0.0"
: (
(Number(totalCounts.rateLimitedCount) /
Number(totalRequests)) *
Expand Down
Loading