-
Notifications
You must be signed in to change notification settings - Fork 543
[TOOL-4673] Dashboard: Enable posthog session recording for nebula app #7267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TOOL-4673] Dashboard: Enable posthog session recording for nebula app #7267
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
WalkthroughThe changes introduce a new prop, Changes
Sequence Diagram(s)sequenceDiagram
participant Layout as NebulaAppLayout
participant PHProvider
participant PostHog
Layout->>PHProvider: Render with disable_session_recording=false
PHProvider->>PostHog: posthog.init(disable_session_recording=false)
Note right of PostHog: Session recording enabled
sequenceDiagram
participant Layout as Bridge/Pay Layout
participant PHProvider
participant PostHog
Layout->>PHProvider: Render with disable_session_recording=true
PHProvider->>PostHog: posthog.init(disable_session_recording=true)
Note right of PostHog: Session recording disabled
Assessment against linked issues
Possibly related PRs
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (7)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (6)
⏰ Context from checks skipped due to timeout of 90000ms (8)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7267 +/- ##
=======================================
Coverage 55.57% 55.57%
=======================================
Files 909 909
Lines 58681 58681
Branches 4167 4167
=======================================
Hits 32612 32612
Misses 25961 25961
Partials 108 108
🚀 New features to boost your workflow:
|
size-limit report 📦
|
Merge activity
|
#7267) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the `PHProvider` component by introducing a `disable_session_recording` prop, allowing for more control over session recording. Additionally, it renames the `Providers` component to `PayProviders` and `BridgeProviders` in their respective files for clarity. ### Detailed summary - Added `disable_session_recording` prop to `<PHProvider>` in multiple files. - Renamed `Providers` to `PayProviders` in `Providers.client.tsx` and `pay/layout.tsx`. - Renamed `Providers` to `BridgeProviders` in `Providers.client.tsx` and `bridge/layout.tsx`. - Updated the `PHProvider` function signature to accept `disable_session_recording` as a prop. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added explicit controls to enable or disable session recording across different sections of the dashboard. - **Refactor** - Renamed provider components for improved clarity in the Bridge and Pay sections. - Updated component usage to reflect new provider names. - **Style** - No visual changes introduced. - **Bug Fixes** - None. - **Documentation** - None. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
09a9080
to
b12725b
Compare
PR-Codex overview
This PR focuses on updating the
PHProvider
component to include adisable_session_recording
prop, modifying the provider usage across various components, and renaming theProviders
function to more specific names likePayProviders
andBridgeProviders
.Detailed summary
PHProvider
to acceptdisable_session_recording
prop.disable_session_recording
totrue
inlayout.tsx
for the dashboard andpay
components.Providers
toPayProviders
inProviders.client.tsx
for thepay
section.Providers
toBridgeProviders
inProviders.client.tsx
for thebridge
section.BridgeLayout
andPayLayout
components to use the new provider names.Summary by CodeRabbit