Skip to content

[TOOL-4673] Dashboard: Enable posthog session recording for nebula app #7267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Jun 3, 2025


PR-Codex overview

This PR focuses on updating the PHProvider component to include a disable_session_recording prop, modifying the provider usage across various components, and renaming the Providers function to more specific names like PayProviders and BridgeProviders.

Detailed summary

  • Updated PHProvider to accept disable_session_recording prop.
  • Set disable_session_recording to true in layout.tsx for the dashboard and pay components.
  • Renamed Providers to PayProviders in Providers.client.tsx for the pay section.
  • Renamed Providers to BridgeProviders in Providers.client.tsx for the bridge section.
  • Updated the BridgeLayout and PayLayout components to use the new provider names.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features
    • Added explicit controls to enable or disable session recording across different sections of the dashboard.
  • Refactor
    • Renamed provider components for improved clarity in the Bridge and Pay sections.
    • Updated component usage to reflect new provider names.
  • Style
    • No visual changes introduced.
  • Bug Fixes
    • None.
  • Documentation
    • None.

Copy link

vercel bot commented Jun 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2025 4:21am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jun 4, 2025 4:21am
login ⬜️ Skipped (Inspect) Jun 4, 2025 4:21am
thirdweb_playground ⬜️ Skipped (Inspect) Jun 4, 2025 4:21am
wallet-ui ⬜️ Skipped (Inspect) Jun 4, 2025 4:21am

@vercel vercel bot temporarily deployed to Preview – docs-v2 June 3, 2025 22:55 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 3, 2025 22:55 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 3, 2025 22:55 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 3, 2025 22:55 Inactive
Copy link

linear bot commented Jun 3, 2025

Copy link

changeset-bot bot commented Jun 3, 2025

⚠️ No Changeset found

Latest commit: b12725b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jun 3, 2025

Walkthrough

The changes introduce a new prop, disable_session_recording, to the PHProvider component, allowing explicit control over session recording in PostHog. The Nebula app layout sets this prop to false (enabling recording), while other areas set it to true. Provider component names are also updated for clarity.

Changes

File(s) Change Summary
.../lib/posthog/Posthog.tsx PHProvider updated to accept disable_session_recording prop; logic updated to use this prop.
.../app/(app)/layout.tsx, .../app/nebula-app/layout.tsx PHProvider instantiated with explicit disable_session_recording prop (true or false).
.../app/bridge/components/client/Providers.client.tsx, .../app/pay/components/client/Providers.client.tsx Provider component renamed (ProvidersBridgeProviders/PayProviders); add disable_session_recording={true}.
.../app/bridge/layout.tsx, .../app/pay/layout.tsx Updated import and usage to match new provider component names.

Sequence Diagram(s)

sequenceDiagram
    participant Layout as NebulaAppLayout
    participant PHProvider
    participant PostHog

    Layout->>PHProvider: Render with disable_session_recording=false
    PHProvider->>PostHog: posthog.init(disable_session_recording=false)
    Note right of PostHog: Session recording enabled
Loading
sequenceDiagram
    participant Layout as Bridge/Pay Layout
    participant PHProvider
    participant PostHog

    Layout->>PHProvider: Render with disable_session_recording=true
    PHProvider->>PostHog: posthog.init(disable_session_recording=true)
    Note right of PostHog: Session recording disabled
Loading

Assessment against linked issues

Objective Addressed Explanation
Enable session recording for Nebula web app in PostHog (TOOL-4673)

Possibly related PRs

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 09a9080 and b12725b.

📒 Files selected for processing (7)
  • apps/dashboard/src/app/(app)/layout.tsx (1 hunks)
  • apps/dashboard/src/app/bridge/components/client/Providers.client.tsx (2 hunks)
  • apps/dashboard/src/app/bridge/layout.tsx (2 hunks)
  • apps/dashboard/src/app/nebula-app/layout.tsx (1 hunks)
  • apps/dashboard/src/app/pay/components/client/Providers.client.tsx (1 hunks)
  • apps/dashboard/src/app/pay/layout.tsx (3 hunks)
  • apps/dashboard/src/lib/posthog/Posthog.tsx (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • apps/dashboard/src/app/(app)/layout.tsx
🚧 Files skipped from review as they are similar to previous changes (6)
  • apps/dashboard/src/app/nebula-app/layout.tsx
  • apps/dashboard/src/app/pay/layout.tsx
  • apps/dashboard/src/app/bridge/layout.tsx
  • apps/dashboard/src/lib/posthog/Posthog.tsx
  • apps/dashboard/src/app/pay/components/client/Providers.client.tsx
  • apps/dashboard/src/app/bridge/components/client/Providers.client.tsx
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Unit Tests
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Build Packages
  • GitHub Check: Size
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MananTank MananTank marked this pull request as ready for review June 3, 2025 22:55
@MananTank MananTank requested review from a team as code owners June 3, 2025 22:55
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jun 3, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.57%. Comparing base (3d1c321) to head (b12725b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7267   +/-   ##
=======================================
  Coverage   55.57%   55.57%           
=======================================
  Files         909      909           
  Lines       58681    58681           
  Branches     4167     4167           
=======================================
  Hits        32612    32612           
  Misses      25961    25961           
  Partials      108      108           
Flag Coverage Δ
packages 55.57% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jun 3, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.57 KB (0%) 1.3 s (0%) 157 ms (+98.12% 🔺) 1.5 s
thirdweb (cjs) 345.38 KB (0%) 7 s (0%) 633 ms (+8.16% 🔺) 7.6 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 45 ms (+585.75% 🔺) 159 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 25 ms (+1584.17% 🔺) 36 ms
thirdweb/react (minimal + tree-shaking) 19.56 KB (0%) 392 ms (0%) 61 ms (+380.83% 🔺) 452 ms

Copy link
Contributor

graphite-app bot commented Jun 4, 2025

Merge activity

#7267)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the `PHProvider` component by introducing a `disable_session_recording` prop, allowing for more control over session recording. Additionally, it renames the `Providers` component to `PayProviders` and `BridgeProviders` in their respective files for clarity.

### Detailed summary
- Added `disable_session_recording` prop to `<PHProvider>` in multiple files.
- Renamed `Providers` to `PayProviders` in `Providers.client.tsx` and `pay/layout.tsx`.
- Renamed `Providers` to `BridgeProviders` in `Providers.client.tsx` and `bridge/layout.tsx`.
- Updated the `PHProvider` function signature to accept `disable_session_recording` as a prop.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

- **New Features**
	- Added explicit controls to enable or disable session recording across different sections of the dashboard.
- **Refactor**
	- Renamed provider components for improved clarity in the Bridge and Pay sections.
	- Updated component usage to reflect new provider names.
- **Style**
	- No visual changes introduced.
- **Bug Fixes**
	- None.
- **Documentation**
	- None.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@graphite-app graphite-app bot force-pushed the 06-04-_tool-4673_dashboard_enable_posthog_session_recording_for_nebula_app branch from 09a9080 to b12725b Compare June 4, 2025 04:13
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 4, 2025 04:13 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 4, 2025 04:13 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 4, 2025 04:13 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 4, 2025 04:13 Inactive
@graphite-app graphite-app bot merged commit b12725b into main Jun 4, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 06-04-_tool-4673_dashboard_enable_posthog_session_recording_for_nebula_app branch June 4, 2025 04:22
@vercel vercel bot temporarily deployed to Production – docs-v2 June 4, 2025 04:22 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui June 4, 2025 04:22 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants