[TOOL-4670] Dashboard: Update Managed Engine CTA, UI tweaks #7266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
""" WalkthroughThe changes refactor the layout and UI for the engine management section. The sidebar navigation is replaced by tab navigation, and the header structure is reorganized for clarity. The "Managed Engine" call-to-action in the engine instances table is simplified, removing plan-based conditional logic and always directing users to contact support. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Layout
participant TabPathLinks
participant EngineLegacyBannerUI
participant EngineInstancesTable
User->>Layout: Load engine management page
Layout->>TabPathLinks: Render navigation tabs
Layout->>EngineLegacyBannerUI: Render legacy banner in header
Layout->>EngineInstancesTable: Render engine instances table
EngineInstancesTable-->>User: Display "Contact Us" CTA (no plan check)
Assessment against linked issues
Suggested reviewers
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (7)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7266 +/- ##
=======================================
Coverage 55.57% 55.57%
=======================================
Files 909 909
Lines 58681 58681
Branches 4167 4167
=======================================
Hits 32612 32612
Misses 25961 25961
Partials 108 108
🚀 New features to boost your workflow:
|
MananTank
force-pushed
the
06-04-_tool-4670_dashboard_update_managed_engine_cta_ui_tweaks
branch
from
a54013d to
95bee42
Compare
size-limit report 📦
|
MananTank
force-pushed
the
06-04-_tool-4670_dashboard_update_managed_engine_cta_ui_tweaks
branch
from
95bee42 to
95ecd6f
Compare
jnsdls
approved these changes
Jun 3, 2025
Merge activity
|
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces a new `bottomLineClassName` prop to the `TabLinks` and `TabPathLinks` components, enhancing customization options for styling. It also simplifies the UI in the `EmptyEngineState` component and updates the layout for better structure and readability.
### Detailed summary
- Added `bottomLineClassName` prop to `TabLinks` and `TabPathLinks`.
- Updated `TabLinks` to use `bottomLineClassName` for styling.
- Simplified `EmptyEngineState` content and button structure.
- Refactored layout in `Layout` component for improved organization.
- Adjusted `EngineLegacyBannerUI` for better spacing and button layout.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
- **Refactor**
- Updated navigation layout for the engine section with new tabbed navigation and improved header structure.
- Adjusted container layouts for more consistent spacing and alignment.
- **Style**
- Restyled the legacy banner, including button order, alignment, and icon adjustments for a clearer appearance.
- Enhanced tab navigation with customizable bottom line styling for better visual integration.
- **Bug Fixes**
- Unified the messaging and actions for adding a managed engine instance, removing plan-based differences for a more consistent user experience.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
graphite-app
bot
force-pushed
the
06-04-_tool-4670_dashboard_update_managed_engine_cta_ui_tweaks
branch
from
95ecd6f to
82035fd
Compare
graphite-app
bot
deleted the
06-04-_tool-4670_dashboard_update_managed_engine_cta_ui_tweaks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR introduces enhancements to the
tabs.tsxcomponent by adding a newbottomLineClassNameprop, modifies the layout inlayout.tsx, and updates theEmptyEngineStatefunction to streamline the user interface and improve the user experience.Detailed summary
bottomLineClassNameprop toTabLinksandTabPathLinkscomponents.TabLinksto applybottomLineClassNamedynamically.EmptyEngineStateto simplify messaging and button structure.layout.tsxfor improved organization and visual clarity.Summary by CodeRabbit
Refactor
Style
Bug Fixes