Skip to content

[SDK] Filter out zero-value token balances in swap UI #7244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented May 31, 2025


PR-Codex overview

This PR enhances the balance fetching logic by adding a condition to ensure that only balances with a value greater than zero are included.

Detailed summary

  • Modified the conditional check from if (matching) to if (matching && b.value > 0n) in fetchBalancesForWallet.tsx.
  • This change ensures that only balances with a positive b.value are pushed into the balances array.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented May 31, 2025

⚠️ No Changeset found

Latest commit: 00d281c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2025 11:05am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2025 11:05am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2025 11:05am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2025 11:05am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2025 11:05am

Copy link
Contributor

coderabbitai bot commented May 31, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels May 31, 2025
Copy link
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review May 31, 2025 10:55
@joaquim-verges joaquim-verges requested review from a team as code owners May 31, 2025 10:55
@joaquim-verges joaquim-verges merged commit 8380a59 into _SDK_Include_native_tokens_in_Insight.getOwnedTokens May 31, 2025
16 of 22 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_Filter_out_zero-value_token_balances_in_swap_UI branch May 31, 2025 10:55
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.24 KB (0%) 1.3 s (0%) 228 ms (+90.07% 🔺) 1.5 s
thirdweb (cjs) 345.4 KB (0%) 7 s (0%) 913 ms (+5.61% 🔺) 7.9 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 103 ms (+1230.26% 🔺) 217 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 47 ms (+1856.73% 🔺) 57 ms
thirdweb/react (minimal + tree-shaking) 19.54 KB (0%) 391 ms (0%) 49 ms (+200.19% 🔺) 439 ms

Copy link

codecov bot commented May 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.59%. Comparing base (9e63e63) to head (00d281c).
Report is 1 commits behind head on _SDK_Include_native_tokens_in_Insight.getOwnedTokens.

Files with missing lines Patch % Lines
...Wallet/screens/Buy/swap/fetchBalancesForWallet.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                                   Coverage Diff                                    @@
##           _SDK_Include_native_tokens_in_Insight.getOwnedTokens    #7244      +/-   ##
========================================================================================
- Coverage                                                 55.60%   55.59%   -0.01%     
========================================================================================
  Files                                                       908      908              
  Lines                                                     58553    58553              
  Branches                                                   4133     4133              
========================================================================================
- Hits                                                      32556    32555       -1     
  Misses                                                    25892    25892              
- Partials                                                    105      106       +1     
Flag Coverage Δ
packages 55.59% <0.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
...Wallet/screens/Buy/swap/fetchBalancesForWallet.tsx 6.15% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant