[Dashboard] Unhide Engine Cloud service #7215
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 55fba51 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis update modifies service metadata and configuration. It updates service descriptions in the core utilities, removes "engineCloud" from a list of hidden services in the dashboard validations, and adds a changeset file to document a patch release for service description updates. No functional or logic changes are introduced. Changes
Sequence Diagram(s)No sequence diagram generated as the changes are limited to metadata and configuration updates without altering control flow or introducing new features. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (8)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
joaquim-verges
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7215 +/- ##
=======================================
Coverage 55.63% 55.63%
=======================================
Files 908 908
Lines 58546 58546
Branches 4127 4127
=======================================
Hits 32572 32572
Misses 25868 25868
Partials 106 106
🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
packages/service-utils/src/core/services.ts (1)
62-68: Consider distinguishing identical descriptions
You’ve updated theinsightservice description to "Indexed data for any EVM chain," which now exactly matches thechainsawservice description. If these services serve different use‐cases or audiences, you might want to tweak one description to highlight their unique value propositions.apps/dashboard/src/components/settings/ApiKeys/validations.ts (1)
149-150: Remove or clarify the stale FIXME
The comment// FIXME: RemoveaboveHIDDEN_SERVICESis ambiguous—please remove it or specify what should be removed to avoid developer confusion.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.changeset/lucky-jobs-relate.md(1 hunks)apps/dashboard/src/components/settings/ApiKeys/validations.ts(1 hunks)packages/service-utils/src/core/services.ts(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Unit Tests
- GitHub Check: Size
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
apps/dashboard/src/components/settings/ApiKeys/validations.ts (1)
150-150: UnhideengineCloudin API key settings
Removing"engineCloud"fromHIDDEN_SERVICESsurfaces it in the dashboard. Ensure you test the UI to confirm that API keys for Engine Cloud are now visible and operable.Consider adding a quick manual or automated UI test to validate visibility.
.changeset/lucky-jobs-relate.md (1)
1-6: Changeset looks correct; consider expanding description
This patch bump correctly targets@thirdweb-dev/service-utilswith the summary "Update service descriptions." Optionally, you could mention thatengineCloudis now unhidden in the dashboard to give more context in the changelog.
| engineCloud: { | ||
| name: "engineCloud", | ||
| title: "Server wallets", | ||
| title: "Engine Cloud", | ||
| description: | ||
| "Server wallets with high transaction throughput and low latency", | ||
| "Transaction API and Server wallets with high transaction throughput and low latency", | ||
| // all actions allowed | ||
| actions: [], | ||
| }, |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Verify removal of legacy references to "Server wallets"
The engineCloud title and description have been updated to reflect its new branding. To ensure no stale references remain, search the codebase for the old title "Server wallets" and update any occurrences (docs, UI copy, tests).
🏁 Script executed:
#!/bin/bash
# Verify no leftover references to the old title
rg "Server wallets"Length of output: 722
Remove all legacy “Server wallets” references
We located several stray “Server wallets” strings that need updating to the new Engine Cloud branding:
- packages/service-utils/src/core/services.ts (lines 77–84)
- description: "Transaction API and Server wallets with high transaction throughput and low latency", + description: "Transaction API and Engine Cloud wallets with high transaction throughput and low latency",
- apps/portal/src/app/engine/v2/configure-wallets/circle-wallet/page.mdx
Replace “Server wallets” with “Engine Cloud wallets” (or your preferred terminology). - apps/portal/src/app/engine/v3/get-started/page.mdx
Update both the explanatory copy and the internal link text/URL to reflect Engine Cloud. - apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/engine/cloud/analytics/ftux.client.tsx
Change the description to remove “Server wallets” in favor of the new branding.
Please apply these replacements so that all references align with the Engine Cloud terminology.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| engineCloud: { | |
| name: "engineCloud", | |
| title: "Server wallets", | |
| title: "Engine Cloud", | |
| description: | |
| "Server wallets with high transaction throughput and low latency", | |
| "Transaction API and Server wallets with high transaction throughput and low latency", | |
| // all actions allowed | |
| actions: [], | |
| }, | |
| engineCloud: { | |
| name: "engineCloud", | |
| title: "Engine Cloud", | |
| description: | |
| "Transaction API and Engine Cloud wallets with high transaction throughput and low latency", | |
| // all actions allowed | |
| actions: [], | |
| }, |
🤖 Prompt for AI Agents
In packages/service-utils/src/core/services.ts around lines 77 to 84, update the
title and description fields to remove any legacy references to "Server wallets"
and replace them with the new branding "Engine Cloud" or "Engine Cloud wallets"
as appropriate. Additionally, search the entire codebase for all occurrences of
"Server wallets" and update them consistently to reflect the new Engine Cloud
terminology, including in documentation, UI copy, tests, and configuration files
as specified in the review comment.
size-limit report 📦
|
Merge activity
|
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on updating service descriptions and modifying hidden services in the codebase.
### Detailed summary
- Updated the description of the `insight` service to "Indexed data for any EVM chain."
- Changed the title of the `engineCloud` service from "Server wallets" to "Engine Cloud."
- Updated the description of the `engineCloud` service to "Transaction API and Server wallets with high transaction throughput and low latency."
- Removed `engineCloud` from the `HIDDEN_SERVICES` array.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
- **Chores**
- Updated service descriptions for improved clarity.
- Refined metadata for select services.
- **Refactor**
- Adjusted visibility of certain services in API key settings.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
graphite-app
bot
force-pushed
the
Update_service_descriptions_and_unhide_Engine_Cloud
branch
from
6b0c113 to
55fba51
Compare
graphite-app
bot
deleted the
Update_service_descriptions_and_unhide_Engine_Cloud
branch
PR-Codex overview
This PR focuses on updating service descriptions and refining the list of hidden services in the codebase.
Detailed summary
insightservice to specify it provides "Indexed data for any EVM chain".engineCloudservice from "Server wallets" to "Engine Cloud".engineCloudservice to clarify its functionality.engineCloudfrom theHIDDEN_SERVICESarray, leaving only "relayer" and "chainsaw".Summary by CodeRabbit