Skip to content

[Dashboard] Fix: Routes page pagination beyond 1, add og image #7136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged

[Dashboard] Fix: Routes page pagination beyond 1, add og image #7136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/dashboard/src/app/(app)/(dashboard)/(bridge)/bridge/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type { Metadata } from "next";
import { getClientThirdwebClient } from "../../../../../@/constants/thirdweb-client.client";
import { UniversalBridgeEmbed } from "./components/client/UniversalBridgeEmbed";

const title = "Universal Bridge: Swap, Bridge, and On-Ramp";
const title = "Universal Bridge: Swap, Bridge, and Onramp";
const description =
"Swap, bridge, and on-ramp to any EVM chain with thirdweb's Universal Bridge.";

Expand Down
Binary file added apps/dashboard/src/app/(app)/(dashboard)/(bridge)/opengraph-image.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
19 changes: 8 additions & 11 deletions apps/dashboard/src/app/(app)/(dashboard)/(bridge)/routes/components/server/routes-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,17 +77,11 @@ export async function RoutesData(props: {

const totalPages = Math.ceil(filteredCount / DEFAULT_PAGE_SIZE);

const activePage = Number(props.searchParams.page || 1);
const pageSize = DEFAULT_PAGE_SIZE;
const startIndex = (activePage - 1) * pageSize;
const endIndex = startIndex + pageSize;
const paginatedRoutes = routesToRender.slice(startIndex, endIndex);

return (
<>
<main>
{/* empty state */}
{paginatedRoutes.length === 0 ? (
{routesToRender.length === 0 ? (
<div className="flex h-[300px] items-center justify-center rounded-lg border p-8 lg:h-[500px]">
<p className="text-2xl">No Results found</p>
</div>
Expand All @@ -111,7 +105,7 @@ export async function RoutesData(props: {
</TableRow>
</TableHeader>
<TableBody>
{paginatedRoutes.map((route) => (
{routesToRender.map((route) => (
<RouteListRow
key={`${route.originToken.chainId}:${route.originToken.address}-${route.destinationToken.chainId}:${route.destinationToken.address}`}
originChainId={route.originToken.chainId}
Expand All @@ -131,7 +125,7 @@ export async function RoutesData(props: {
</TableContainer>
) : (
<ul className="grid grid-cols-1 gap-4 md:grid-cols-2 lg:grid-cols-3">
{paginatedRoutes.map((route) => (
{routesToRender.map((route) => (
<li
key={`${route.originToken.chainId}:${route.originToken.address}-${route.destinationToken.chainId}:${route.destinationToken.address}`}
className="h-full"
Expand All @@ -155,12 +149,15 @@ export async function RoutesData(props: {
</main>
<div className="h-10" />
{totalPages > 1 && (
<ChainlistPagination totalPages={totalPages} activePage={activePage} />
<ChainlistPagination
totalPages={totalPages}
activePage={Number(props.searchParams.page) || 1}
/>
)}
<div className="h-4" />
<p className="text-balance text-center text-muted-foreground text-sm">
Showing{" "}
<span className="text-accent-foreground">{paginatedRoutes.length}</span>{" "}
<span className="text-accent-foreground">{routesToRender.length}</span>{" "}
out of{" "}
{filteredCount !== totalCount ? (
<>
Expand Down
2 changes: 1 addition & 1 deletion apps/dashboard/src/app/(app)/(dashboard)/(bridge)/routes/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
type SearchParams,
} from "./components/server/routes-table";

const title = "Routes: Swap, Bridge, and On-Ramp";
const title = "Universal Bridge Routes: Swap, Bridge, and Onramp";
const description =
"A list of token routes for swapping, bridging, and on-ramping between EVM chains with thirdweb.";

Expand Down
Loading